From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: In async mode, use target_stop to stop the inferior
Date: Fri, 14 Mar 2008 08:02:00 -0000 [thread overview]
Message-ID: <200803140802.01625.pedro@codesourcery.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 244 bytes --]
We do have a target method for this now. Obviouly for every
async target other than "target (extended-)async", this wasn't
working.
Installed as obvious (after testing with a local gdbserver with
the testsuite and manually).
--
Pedro Alves
[-- Attachment #2: use_target_stop.diff --]
[-- Type: text/x-diff, Size: 1885 bytes --]
2008-03-14 Pedro Alves <pedro@codesourcery.com>
* inf-loop.c (inferior_event_handler): Don't include remote.h.
Call target_stop in the INF_QUIT_REQ case.
* Makefile.in (inf-loop.o): Update.
---
gdb/Makefile.in | 2 +-
gdb/inf-loop.c | 8 ++------
2 files changed, 3 insertions(+), 7 deletions(-)
Index: src/gdb/inf-loop.c
===================================================================
--- src.orig/gdb/inf-loop.c 2008-03-14 07:01:53.000000000 +0000
+++ src/gdb/inf-loop.c 2008-03-14 07:11:33.000000000 +0000
@@ -23,7 +23,6 @@
#include "event-loop.h"
#include "event-top.h"
#include "inf-loop.h"
-#include "remote.h"
#include "exceptions.h"
static int fetch_inferior_event_wrapper (gdb_client_data client_data);
@@ -83,11 +82,8 @@ inferior_event_handler (enum inferior_ev
do_all_intermediate_continuations ();
break;
- case INF_QUIT_REQ:
- /* FIXME: ezannoni 1999-10-04. This call should really be a
- target vector entry, so that it can be used for any kind of
- targets. */
- async_remote_interrupt_twice (NULL);
+ case INF_QUIT_REQ:
+ target_stop ();
break;
case INF_TIMER:
Index: src/gdb/Makefile.in
===================================================================
--- src.orig/gdb/Makefile.in 2008-03-14 07:01:53.000000000 +0000
+++ src/gdb/Makefile.in 2008-03-14 07:11:25.000000000 +0000
@@ -2293,7 +2293,7 @@ infcmd.o: infcmd.c $(defs_h) $(gdb_strin
$(solib_h) $(gdb_assert_h) $(observer_h) $(target_descriptions_h) \
$(user_regs_h)
inf-loop.o: inf-loop.c $(defs_h) $(inferior_h) $(target_h) $(event_loop_h) \
- $(event_top_h) $(inf_loop_h) $(remote_h) $(exceptions_h)
+ $(event_top_h) $(inf_loop_h) $(exceptions_h)
inflow.o: inflow.c $(defs_h) $(frame_h) $(inferior_h) $(command_h) \
$(serial_h) $(terminal_h) $(target_h) $(gdbthread_h) $(gdb_string_h) \
$(inflow_h) $(gdb_select_h)
next reply other threads:[~2008-03-14 8:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-14 8:02 Pedro Alves [this message]
2008-03-14 14:39 ` Daniel Jacobowitz
2008-03-14 15:19 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803140802.01625.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox