From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1321 invoked by alias); 14 Mar 2008 08:02:42 -0000 Received: (qmail 1307 invoked by uid 22791); 14 Mar 2008 08:02:41 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 14 Mar 2008 08:01:54 +0000 Received: (qmail 27888 invoked from network); 14 Mar 2008 08:01:52 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 14 Mar 2008 08:01:52 -0000 From: Pedro Alves Subject: In async mode, use target_stop to stop the inferior Date: Fri, 14 Mar 2008 08:02:00 -0000 User-Agent: KMail/1.9.6 (enterprise 0.20070907.709405) MIME-Version: 1.0 To: gdb-patches@sourceware.org Content-Type: Multipart/Mixed; boundary="Boundary-00=_5Dj2HwwMoA8MbXi" Message-Id: <200803140802.01625.pedro@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00160.txt.bz2 --Boundary-00=_5Dj2HwwMoA8MbXi Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 244 We do have a target method for this now. Obviouly for every async target other than "target (extended-)async", this wasn't working. Installed as obvious (after testing with a local gdbserver with the testsuite and manually). -- Pedro Alves --Boundary-00=_5Dj2HwwMoA8MbXi Content-Type: text/x-diff; charset="utf-8"; name="use_target_stop.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="use_target_stop.diff" Content-length: 1885 2008-03-14 Pedro Alves * inf-loop.c (inferior_event_handler): Don't include remote.h. Call target_stop in the INF_QUIT_REQ case. * Makefile.in (inf-loop.o): Update. --- gdb/Makefile.in | 2 +- gdb/inf-loop.c | 8 ++------ 2 files changed, 3 insertions(+), 7 deletions(-) Index: src/gdb/inf-loop.c =================================================================== --- src.orig/gdb/inf-loop.c 2008-03-14 07:01:53.000000000 +0000 +++ src/gdb/inf-loop.c 2008-03-14 07:11:33.000000000 +0000 @@ -23,7 +23,6 @@ #include "event-loop.h" #include "event-top.h" #include "inf-loop.h" -#include "remote.h" #include "exceptions.h" static int fetch_inferior_event_wrapper (gdb_client_data client_data); @@ -83,11 +82,8 @@ inferior_event_handler (enum inferior_ev do_all_intermediate_continuations (); break; - case INF_QUIT_REQ: - /* FIXME: ezannoni 1999-10-04. This call should really be a - target vector entry, so that it can be used for any kind of - targets. */ - async_remote_interrupt_twice (NULL); + case INF_QUIT_REQ: + target_stop (); break; case INF_TIMER: Index: src/gdb/Makefile.in =================================================================== --- src.orig/gdb/Makefile.in 2008-03-14 07:01:53.000000000 +0000 +++ src/gdb/Makefile.in 2008-03-14 07:11:25.000000000 +0000 @@ -2293,7 +2293,7 @@ infcmd.o: infcmd.c $(defs_h) $(gdb_strin $(solib_h) $(gdb_assert_h) $(observer_h) $(target_descriptions_h) \ $(user_regs_h) inf-loop.o: inf-loop.c $(defs_h) $(inferior_h) $(target_h) $(event_loop_h) \ - $(event_top_h) $(inf_loop_h) $(remote_h) $(exceptions_h) + $(event_top_h) $(inf_loop_h) $(exceptions_h) inflow.o: inflow.c $(defs_h) $(frame_h) $(inferior_h) $(command_h) \ $(serial_h) $(terminal_h) $(target_h) $(gdbthread_h) $(gdb_string_h) \ $(inflow_h) $(gdb_select_h) --Boundary-00=_5Dj2HwwMoA8MbXi--