Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <vladimir@codesourcery.com>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Implement -thread-info.
Date: Mon, 10 Mar 2008 07:59:00 -0000	[thread overview]
Message-ID: <200803101059.11860.vladimir@codesourcery.com> (raw)
In-Reply-To: <18386.61722.520179.46104@kahikatea.snap.net.nz>

On Saturday 08 March 2008 23:03:38 Nick Roberts wrote:
> 
>  > -static void
>  > -info_threads_command (char *arg, int from_tty)
>  > +/* Prints the list of threads and their details on UIOUT.
> 
>  > +   This is a version of 'info_thread_command' suitable for
>  > +   use from MI.  
> 
> Isn't this comment out of date now that info_threads_command calls
> mi_info_threads?

It is out of date, indeed.

> 
>  > +   If REQESTED_THREAD is not -1, it's the GDB id of the thread
>  > +   that should be printed.  Otherwise, all threads are
>  > +   printed.  */
>  > +void
>  > +mi_info_threads (struct ui_out *uiout, int requested_thread)
>  >  {
> 
> As mi_info_threads is now not mi specific, should it be called something like
> info_threads_1?

The "_1" is a bit misleading, as the function can print information about all
threads just fine. How about "print_thread_info"?

- Volodya


  reply	other threads:[~2008-03-10  7:59 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-17 15:33 Vladimir Prus
2008-02-18  6:26 ` Nick Roberts
2008-02-18  7:38   ` Vladimir Prus
2008-02-18 21:45     ` Nick Roberts
2008-02-20 11:28       ` Vladimir Prus
2008-02-20 19:07         ` Eli Zaretskii
2008-02-20 19:38         ` Nick Roberts
2008-02-20 20:03           ` Vladimir Prus
2008-02-26  0:58         ` Nick Roberts
2008-02-26  1:21           ` Daniel Jacobowitz
2008-03-23  4:56             ` Nick Roberts
2008-03-23  7:38               ` Vladimir Prus
2008-03-23 16:22               ` Daniel Jacobowitz
2008-03-08 15:50           ` Vladimir Prus
2008-03-08 15:55         ` Vladimir Prus
2008-03-08 20:04           ` Nick Roberts
2008-03-10  7:59             ` Vladimir Prus [this message]
2008-03-10  9:13               ` Nick Roberts
2008-03-14 10:17           ` Vladimir Prus
2008-03-17 18:40             ` Michael Snyder
2008-03-14 15:08           ` Daniel Jacobowitz
2008-03-14 15:11             ` Daniel Jacobowitz
2008-03-14 17:04               ` Vladimir Prus
2008-03-14 18:04                 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803101059.11860.vladimir@codesourcery.com \
    --to=vladimir@codesourcery.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox