From: Vladimir Prus <vladimir@codesourcery.com>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Implement -thread-info.
Date: Wed, 20 Feb 2008 20:03:00 -0000 [thread overview]
Message-ID: <200802202302.43620.vladimir@codesourcery.com> (raw)
In-Reply-To: <18364.33141.401534.130390@kahikatea.snap.net.nz>
On Wednesday 20 February 2008 22:37:25 Nick Roberts wrote:
> > > Also do you want to
> > > catch errors in print_stack_frame?
> >
> > Yes, why not? A typical error is when we have a char* parameter pointing to
> > something not very accessible, in which case I'd prefer print_stack_frame
> > to catch this error, as opposed to -thread-info outright dying.
>
> If there is an error then presumably you want MI to catch (and report) it.
> I don't know if this is a problem, in practice, because I don't know how to
> get print_stack_frame to fail.
Well, the only error I know is failure to access memory when printing
arguments, which I probably don't want to convert into ^error of the entire
command. Should we run into really fatal errors that should terminate
-thread-info, we can always change.
>
> > > > I don't know what problem of return type you refer to -- can you
> > > > clarify?
> > >
> > > That, in Denis' patch, gdb_thread_info returns type enum gdb_rc but
> > > catch_exceptions_with_msg returns type int. (just like gdb_breakpoint and
> > > break_command_really did for a while).
> >
> > This problem does not exist in my patch, as catch_exceptions_with_msg is
> > just not used.
>
> You misunderstand. The problem you were asking about was in Denis' patch.
> I never said it was in yours.
OK.
- Volodya
next prev parent reply other threads:[~2008-02-20 20:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-17 15:33 Vladimir Prus
2008-02-18 6:26 ` Nick Roberts
2008-02-18 7:38 ` Vladimir Prus
2008-02-18 21:45 ` Nick Roberts
2008-02-20 11:28 ` Vladimir Prus
2008-02-20 19:07 ` Eli Zaretskii
2008-02-20 19:38 ` Nick Roberts
2008-02-20 20:03 ` Vladimir Prus [this message]
2008-02-26 0:58 ` Nick Roberts
2008-02-26 1:21 ` Daniel Jacobowitz
2008-03-23 4:56 ` Nick Roberts
2008-03-23 7:38 ` Vladimir Prus
2008-03-23 16:22 ` Daniel Jacobowitz
2008-03-08 15:50 ` Vladimir Prus
2008-03-08 15:55 ` Vladimir Prus
2008-03-08 20:04 ` Nick Roberts
2008-03-10 7:59 ` Vladimir Prus
2008-03-10 9:13 ` Nick Roberts
2008-03-14 10:17 ` Vladimir Prus
2008-03-17 18:40 ` Michael Snyder
2008-03-14 15:08 ` Daniel Jacobowitz
2008-03-14 15:11 ` Daniel Jacobowitz
2008-03-14 17:04 ` Vladimir Prus
2008-03-14 18:04 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802202302.43620.vladimir@codesourcery.com \
--to=vladimir@codesourcery.com \
--cc=gdb-patches@sources.redhat.com \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox