From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18459 invoked by alias); 20 Feb 2008 20:03:09 -0000 Received: (qmail 18443 invoked by uid 22791); 20 Feb 2008 20:03:08 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 20 Feb 2008 20:02:51 +0000 Received: (qmail 21460 invoked from network); 20 Feb 2008 20:02:49 -0000 Received: from unknown (HELO localhost) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 20 Feb 2008 20:02:49 -0000 From: Vladimir Prus To: Nick Roberts Subject: Re: [RFA] Implement -thread-info. Date: Wed, 20 Feb 2008 20:03:00 -0000 User-Agent: KMail/1.9.6 (enterprise 0.20070907.709405) Cc: gdb-patches@sources.redhat.com References: <200802171833.26673.vladimir@codesourcery.com> <200802201427.36288.vladimir@codesourcery.com> <18364.33141.401534.130390@kahikatea.snap.net.nz> In-Reply-To: <18364.33141.401534.130390@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200802202302.43620.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00338.txt.bz2 On Wednesday 20 February 2008 22:37:25 Nick Roberts wrote: > > > Also do you want to > > > catch errors in print_stack_frame? > > > > Yes, why not? A typical error is when we have a char* parameter pointing to > > something not very accessible, in which case I'd prefer print_stack_frame > > to catch this error, as opposed to -thread-info outright dying. > > If there is an error then presumably you want MI to catch (and report) it. > I don't know if this is a problem, in practice, because I don't know how to > get print_stack_frame to fail. Well, the only error I know is failure to access memory when printing arguments, which I probably don't want to convert into ^error of the entire command. Should we run into really fatal errors that should terminate -thread-info, we can always change. > > > > > I don't know what problem of return type you refer to -- can you > > > > clarify? > > > > > > That, in Denis' patch, gdb_thread_info returns type enum gdb_rc but > > > catch_exceptions_with_msg returns type int. (just like gdb_breakpoint and > > > break_command_really did for a while). > > > > This problem does not exist in my patch, as catch_exceptions_with_msg is > > just not used. > > You misunderstand. The problem you were asking about was in Denis' patch. > I never said it was in yours. OK. - Volodya