From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26603 invoked by alias); 10 Mar 2008 07:59:32 -0000 Received: (qmail 26594 invoked by uid 22791); 10 Mar 2008 07:59:32 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 10 Mar 2008 07:59:15 +0000 Received: (qmail 13869 invoked from network); 10 Mar 2008 07:59:13 -0000 Received: from unknown (HELO localhost) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 10 Mar 2008 07:59:13 -0000 From: Vladimir Prus To: Nick Roberts Subject: Re: [RFA] Implement -thread-info. Date: Mon, 10 Mar 2008 07:59:00 -0000 User-Agent: KMail/1.9.6 (enterprise 0.20070907.709405) Cc: gdb-patches@sources.redhat.com References: <200802171833.26673.vladimir@codesourcery.com> <18386.61722.520179.46104@kahikatea.snap.net.nz> In-Reply-To: <18386.61722.520179.46104@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200803101059.11860.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00084.txt.bz2 On Saturday 08 March 2008 23:03:38 Nick Roberts wrote: > > > -static void > > -info_threads_command (char *arg, int from_tty) > > +/* Prints the list of threads and their details on UIOUT. > > > + This is a version of 'info_thread_command' suitable for > > + use from MI. > > Isn't this comment out of date now that info_threads_command calls > mi_info_threads? It is out of date, indeed. > > > + If REQESTED_THREAD is not -1, it's the GDB id of the thread > > + that should be printed. Otherwise, all threads are > > + printed. */ > > +void > > +mi_info_threads (struct ui_out *uiout, int requested_thread) > > { > > As mi_info_threads is now not mi specific, should it be called something like > info_threads_1? The "_1" is a bit misleading, as the function can print information about all threads just fine. How about "print_thread_info"? - Volodya