From: Daniel Jacobowitz <drow@false.org>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Patch: 'show args' -vs- '--args'
Date: Thu, 28 Feb 2008 16:57:00 -0000 [thread overview]
Message-ID: <20080228165420.GB1287@caradoc.them.org> (raw)
In-Reply-To: <m3lk55m5p0.fsf@fleche.redhat.com>
On Thu, Feb 28, 2008 at 09:00:43AM -0700, Tom Tromey wrote:
> I suppose it could if we did this:
>
> deprecated_show_value_hack (file, from_tty, c, get_inferior_args ());
>
> i.e., we didn't print the passed-in value -- that value is already
> known to be wrong.
>
> It seems a little weird to do this, given that this function is named
> 'deprecated_...', and given that there is an existing hook that does
> exactly what is needed here. That aid I'm happy to resubmit a patch
> based on this idea if that is what you want, just let me know.
I'm fine with either the above, or setting pre_show_hook manually; I
didn't like add_setshow_optional_filename_cmd having a different
signature than all the similar setshow functions.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-02-28 16:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-03 20:50 Tom Tromey
2008-02-13 1:54 ` Tom Tromey
2008-02-28 16:50 ` Daniel Jacobowitz
2008-02-28 16:54 ` Tom Tromey
2008-02-28 16:57 ` Daniel Jacobowitz [this message]
2008-02-28 17:19 ` Tom Tromey
2008-02-28 17:28 ` Daniel Jacobowitz
2008-02-28 17:40 ` Tom Tromey
2008-02-28 18:53 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080228165420.GB1287@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox