Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: Re: Patch: 'show args' -vs- '--args'
Date: Thu, 28 Feb 2008 16:54:00 -0000	[thread overview]
Message-ID: <m3lk55m5p0.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20080228164043.GD31695@caradoc.them.org> (Daniel Jacobowitz's message of "Thu\, 28 Feb 2008 11\:40\:43 -0500")

>>>>> "Daniel" == Daniel Jacobowitz <drow@false.org> writes:

Daniel> Anyway, now that it's a show_func...

>> +notice_args_read (struct cmd_list_element *c)
>> {
>> -  deprecated_show_value_hack (file, from_tty, c, value);
>> /* Might compute the value.  */
>> get_inferior_args ();
>> }

Daniel> wouldn't just swapping those two function calls fix it?

I suppose it could if we did this:

   deprecated_show_value_hack (file, from_tty, c, get_inferior_args ());

i.e., we didn't print the passed-in value -- that value is already
known to be wrong.

It seems a little weird to do this, given that this function is named
'deprecated_...', and given that there is an existing hook that does
exactly what is needed here.  That aid I'm happy to resubmit a patch
based on this idea if that is what you want, just let me know.

Tom


  reply	other threads:[~2008-02-28 16:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-03 20:50 Tom Tromey
2008-02-13  1:54 ` Tom Tromey
2008-02-28 16:50 ` Daniel Jacobowitz
2008-02-28 16:54   ` Tom Tromey [this message]
2008-02-28 16:57     ` Daniel Jacobowitz
2008-02-28 17:19       ` Tom Tromey
2008-02-28 17:28         ` Daniel Jacobowitz
2008-02-28 17:40       ` Tom Tromey
2008-02-28 18:53         ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3lk55m5p0.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox