From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11619 invoked by alias); 28 Feb 2008 16:54:45 -0000 Received: (qmail 11611 invoked by uid 22791); 28 Feb 2008 16:54:44 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 28 Feb 2008 16:54:23 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id D2CD7983A1; Thu, 28 Feb 2008 16:54:21 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id B1E0B98140; Thu, 28 Feb 2008 16:54:21 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JUm1U-0000Pf-Ua; Thu, 28 Feb 2008 11:54:20 -0500 Date: Thu, 28 Feb 2008 16:57:00 -0000 From: Daniel Jacobowitz To: Tom Tromey Cc: gdb-patches@sources.redhat.com Subject: Re: Patch: 'show args' -vs- '--args' Message-ID: <20080228165420.GB1287@caradoc.them.org> Mail-Followup-To: Tom Tromey , gdb-patches@sources.redhat.com References: <20080228164043.GD31695@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00478.txt.bz2 On Thu, Feb 28, 2008 at 09:00:43AM -0700, Tom Tromey wrote: > I suppose it could if we did this: > > deprecated_show_value_hack (file, from_tty, c, get_inferior_args ()); > > i.e., we didn't print the passed-in value -- that value is already > known to be wrong. > > It seems a little weird to do this, given that this function is named > 'deprecated_...', and given that there is an existing hook that does > exactly what is needed here. That aid I'm happy to resubmit a patch > based on this idea if that is what you want, just let me know. I'm fine with either the above, or setting pre_show_hook manually; I didn't like add_setshow_optional_filename_cmd having a different signature than all the similar setshow functions. -- Daniel Jacobowitz CodeSourcery