Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [RFA/ppc] Set PC register type to code_ptr
@ 2008-02-04 21:29 Joel Brobecker
  2008-02-04 21:31 ` Joel Brobecker
  2008-02-26  3:55 ` Daniel Jacobowitz
  0 siblings, 2 replies; 4+ messages in thread
From: Joel Brobecker @ 2008-02-04 21:29 UTC (permalink / raw)
  To: gdb-patches

[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]

Hello,

Noticed with the recent testcase that I introduced, "ptype $pc"
returns an integer type instead of a pointer to function. Fixed
by updating the various XML descriptions and regenerating the
associated .c files.

2008-02-04  Joel Brobecker  <brobecker@adacore.com>

        * features/rs6000/power-core.xml, features/rs6000/power64-core.xml
        features/rs6000/powerpc-601.xml, features/rs6000/rs6000.xml:
        Set PC register type to "code_ptr".
        * features/rs6000/powerpc-32.c, features/rs6000/powerpc-403.c,
        features/rs6000/powerpc-403gc.c, features/rs6000/powerpc-505.c,
        features/rs6000/powerpc-601.c, features/rs6000/powerpc-602.c,
        features/rs6000/powerpc-603.c, features/rs6000/powerpc-604.c,
        features/rs6000/powerpc-64.c, features/rs6000/powerpc-7400.c,
        features/rs6000/powerpc-750.c, features/rs6000/powerpc-860.c,
        features/rs6000/powerpc-e500.c, features/rs6000/rs6000.c:
        Regenerate.

Tested on ppc-aix. No regression. Fixes:

    FAIL: ptype.exp: ptype $pc.

OK to apply?

Thanks,
-- 
Joel

[-- Attachment #2: features-ppc.diff --]
[-- Type: text/plain, Size: 15513 bytes --]

Index: features/rs6000/power-core.xml
===================================================================
RCS file: /cvs/src/src/gdb/features/rs6000/power-core.xml,v
retrieving revision 1.3
diff -u -p -r1.3 power-core.xml
--- features/rs6000/power-core.xml	1 Jan 2008 22:53:14 -0000	1.3
+++ features/rs6000/power-core.xml	4 Feb 2008 21:22:40 -0000
@@ -40,7 +40,7 @@
   <reg name="r30" bitsize="32" type="uint32"/>
   <reg name="r31" bitsize="32" type="uint32"/>
 
-  <reg name="pc" bitsize="32" type="uint32" regnum="64"/>
+  <reg name="pc" bitsize="32" type="code_ptr" regnum="64"/>
   <reg name="msr" bitsize="32" type="uint32"/>
   <reg name="cr" bitsize="32" type="uint32"/>
   <reg name="lr" bitsize="32" type="uint32"/>
Index: features/rs6000/power64-core.xml
===================================================================
RCS file: /cvs/src/src/gdb/features/rs6000/power64-core.xml,v
retrieving revision 1.3
diff -u -p -r1.3 power64-core.xml
--- features/rs6000/power64-core.xml	1 Jan 2008 22:53:14 -0000	1.3
+++ features/rs6000/power64-core.xml	4 Feb 2008 21:22:40 -0000
@@ -40,7 +40,7 @@
   <reg name="r30" bitsize="64" type="uint64"/>
   <reg name="r31" bitsize="64" type="uint64"/>
 
-  <reg name="pc" bitsize="64" type="uint64" regnum="64"/>
+  <reg name="pc" bitsize="64" type="code_ptr" regnum="64"/>
   <reg name="msr" bitsize="64" type="uint64"/>
   <reg name="cr" bitsize="32" type="uint32"/>
   <reg name="lr" bitsize="64" type="uint64"/>
Index: features/rs6000/powerpc-601.xml
===================================================================
RCS file: /cvs/src/src/gdb/features/rs6000/powerpc-601.xml,v
retrieving revision 1.2
diff -u -p -r1.2 powerpc-601.xml
--- features/rs6000/powerpc-601.xml	1 Jan 2008 22:53:14 -0000	1.2
+++ features/rs6000/powerpc-601.xml	4 Feb 2008 21:22:40 -0000
@@ -46,7 +46,7 @@
     <reg name="r30" bitsize="32"/>
     <reg name="r31" bitsize="32"/>
 
-    <reg name="pc" bitsize="32" regnum="64"/>
+    <reg name="pc" bitsize="32" type="code_ptr" regnum="64"/>
     <reg name="msr" bitsize="32"/>
     <reg name="cr" bitsize="32"/>
     <reg name="lr" bitsize="32"/>
Index: features/rs6000/rs6000.xml
===================================================================
RCS file: /cvs/src/src/gdb/features/rs6000/rs6000.xml,v
retrieving revision 1.2
diff -u -p -r1.2 rs6000.xml
--- features/rs6000/rs6000.xml	1 Jan 2008 22:53:14 -0000	1.2
+++ features/rs6000/rs6000.xml	4 Feb 2008 21:22:42 -0000
@@ -48,7 +48,7 @@
     <reg name="r30" bitsize="32"/>
     <reg name="r31" bitsize="32"/>
 
-    <reg name="pc" bitsize="32" regnum="64"/>
+    <reg name="pc" bitsize="32" type="code_ptr" regnum="64"/>
     <reg name="msr" bitsize="32"/>
     <reg name="cnd" bitsize="32"/>
     <reg name="lr" bitsize="32"/>
Index: features/rs6000/powerpc-32.c
===================================================================
RCS file: /cvs/src/src/gdb/features/rs6000/powerpc-32.c,v
retrieving revision 1.2
diff -u -p -r1.2 powerpc-32.c
--- features/rs6000/powerpc-32.c	5 Nov 2007 21:55:39 -0000	1.2
+++ features/rs6000/powerpc-32.c	4 Feb 2008 21:22:40 -0000
@@ -47,7 +47,7 @@ initialize_tdesc_powerpc_32 (void)
   tdesc_create_reg (feature, "r29", 29, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "r30", 30, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "r31", 31, 1, NULL, 32, "uint32");
-  tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "uint32");
+  tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "code_ptr");
   tdesc_create_reg (feature, "msr", 65, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "cr", 66, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "lr", 67, 1, NULL, 32, "uint32");
Index: features/rs6000/powerpc-403.c
===================================================================
RCS file: /cvs/src/src/gdb/features/rs6000/powerpc-403.c,v
retrieving revision 1.2
diff -u -p -r1.2 powerpc-403.c
--- features/rs6000/powerpc-403.c	5 Nov 2007 21:55:39 -0000	1.2
+++ features/rs6000/powerpc-403.c	4 Feb 2008 21:22:40 -0000
@@ -45,7 +45,7 @@ initialize_tdesc_powerpc_403 (void)
   tdesc_create_reg (feature, "r29", 29, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "r30", 30, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "r31", 31, 1, NULL, 32, "uint32");
-  tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "uint32");
+  tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "code_ptr");
   tdesc_create_reg (feature, "msr", 65, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "cr", 66, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "lr", 67, 1, NULL, 32, "uint32");
Index: features/rs6000/powerpc-403gc.c
===================================================================
RCS file: /cvs/src/src/gdb/features/rs6000/powerpc-403gc.c,v
retrieving revision 1.2
diff -u -p -r1.2 powerpc-403gc.c
--- features/rs6000/powerpc-403gc.c	5 Nov 2007 21:55:39 -0000	1.2
+++ features/rs6000/powerpc-403gc.c	4 Feb 2008 21:22:40 -0000
@@ -45,7 +45,7 @@ initialize_tdesc_powerpc_403gc (void)
   tdesc_create_reg (feature, "r29", 29, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "r30", 30, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "r31", 31, 1, NULL, 32, "uint32");
-  tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "uint32");
+  tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "code_ptr");
   tdesc_create_reg (feature, "msr", 65, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "cr", 66, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "lr", 67, 1, NULL, 32, "uint32");
Index: features/rs6000/powerpc-505.c
===================================================================
RCS file: /cvs/src/src/gdb/features/rs6000/powerpc-505.c,v
retrieving revision 1.2
diff -u -p -r1.2 powerpc-505.c
--- features/rs6000/powerpc-505.c	5 Nov 2007 21:55:39 -0000	1.2
+++ features/rs6000/powerpc-505.c	4 Feb 2008 21:22:40 -0000
@@ -45,7 +45,7 @@ initialize_tdesc_powerpc_505 (void)
   tdesc_create_reg (feature, "r29", 29, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "r30", 30, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "r31", 31, 1, NULL, 32, "uint32");
-  tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "uint32");
+  tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "code_ptr");
   tdesc_create_reg (feature, "msr", 65, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "cr", 66, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "lr", 67, 1, NULL, 32, "uint32");
Index: features/rs6000/powerpc-601.c
===================================================================
RCS file: /cvs/src/src/gdb/features/rs6000/powerpc-601.c,v
retrieving revision 1.1
diff -u -p -r1.1 powerpc-601.c
--- features/rs6000/powerpc-601.c	15 Oct 2007 19:41:56 -0000	1.1
+++ features/rs6000/powerpc-601.c	4 Feb 2008 21:22:40 -0000
@@ -45,7 +45,7 @@ initialize_tdesc_powerpc_601 (void)
   tdesc_create_reg (feature, "r29", 29, 1, NULL, 32, "int");
   tdesc_create_reg (feature, "r30", 30, 1, NULL, 32, "int");
   tdesc_create_reg (feature, "r31", 31, 1, NULL, 32, "int");
-  tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "int");
+  tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "code_ptr");
   tdesc_create_reg (feature, "msr", 65, 1, NULL, 32, "int");
   tdesc_create_reg (feature, "cr", 66, 1, NULL, 32, "int");
   tdesc_create_reg (feature, "lr", 67, 1, NULL, 32, "int");
Index: features/rs6000/powerpc-602.c
===================================================================
RCS file: /cvs/src/src/gdb/features/rs6000/powerpc-602.c,v
retrieving revision 1.2
diff -u -p -r1.2 powerpc-602.c
--- features/rs6000/powerpc-602.c	5 Nov 2007 21:55:39 -0000	1.2
+++ features/rs6000/powerpc-602.c	4 Feb 2008 21:22:41 -0000
@@ -45,7 +45,7 @@ initialize_tdesc_powerpc_602 (void)
   tdesc_create_reg (feature, "r29", 29, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "r30", 30, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "r31", 31, 1, NULL, 32, "uint32");
-  tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "uint32");
+  tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "code_ptr");
   tdesc_create_reg (feature, "msr", 65, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "cr", 66, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "lr", 67, 1, NULL, 32, "uint32");
Index: features/rs6000/powerpc-603.c
===================================================================
RCS file: /cvs/src/src/gdb/features/rs6000/powerpc-603.c,v
retrieving revision 1.2
diff -u -p -r1.2 powerpc-603.c
--- features/rs6000/powerpc-603.c	5 Nov 2007 21:55:39 -0000	1.2
+++ features/rs6000/powerpc-603.c	4 Feb 2008 21:22:41 -0000
@@ -45,7 +45,7 @@ initialize_tdesc_powerpc_603 (void)
   tdesc_create_reg (feature, "r29", 29, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "r30", 30, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "r31", 31, 1, NULL, 32, "uint32");
-  tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "uint32");
+  tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "code_ptr");
   tdesc_create_reg (feature, "msr", 65, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "cr", 66, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "lr", 67, 1, NULL, 32, "uint32");
Index: features/rs6000/powerpc-604.c
===================================================================
RCS file: /cvs/src/src/gdb/features/rs6000/powerpc-604.c,v
retrieving revision 1.2
diff -u -p -r1.2 powerpc-604.c
--- features/rs6000/powerpc-604.c	5 Nov 2007 21:55:39 -0000	1.2
+++ features/rs6000/powerpc-604.c	4 Feb 2008 21:22:41 -0000
@@ -45,7 +45,7 @@ initialize_tdesc_powerpc_604 (void)
   tdesc_create_reg (feature, "r29", 29, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "r30", 30, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "r31", 31, 1, NULL, 32, "uint32");
-  tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "uint32");
+  tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "code_ptr");
   tdesc_create_reg (feature, "msr", 65, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "cr", 66, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "lr", 67, 1, NULL, 32, "uint32");
Index: features/rs6000/powerpc-64.c
===================================================================
RCS file: /cvs/src/src/gdb/features/rs6000/powerpc-64.c,v
retrieving revision 1.2
diff -u -p -r1.2 powerpc-64.c
--- features/rs6000/powerpc-64.c	5 Nov 2007 21:55:39 -0000	1.2
+++ features/rs6000/powerpc-64.c	4 Feb 2008 21:22:41 -0000
@@ -47,7 +47,7 @@ initialize_tdesc_powerpc_64 (void)
   tdesc_create_reg (feature, "r29", 29, 1, NULL, 64, "uint64");
   tdesc_create_reg (feature, "r30", 30, 1, NULL, 64, "uint64");
   tdesc_create_reg (feature, "r31", 31, 1, NULL, 64, "uint64");
-  tdesc_create_reg (feature, "pc", 64, 1, NULL, 64, "uint64");
+  tdesc_create_reg (feature, "pc", 64, 1, NULL, 64, "code_ptr");
   tdesc_create_reg (feature, "msr", 65, 1, NULL, 64, "uint64");
   tdesc_create_reg (feature, "cr", 66, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "lr", 67, 1, NULL, 64, "uint64");
Index: features/rs6000/powerpc-7400.c
===================================================================
RCS file: /cvs/src/src/gdb/features/rs6000/powerpc-7400.c,v
retrieving revision 1.2
diff -u -p -r1.2 powerpc-7400.c
--- features/rs6000/powerpc-7400.c	5 Nov 2007 21:55:39 -0000	1.2
+++ features/rs6000/powerpc-7400.c	4 Feb 2008 21:22:41 -0000
@@ -45,7 +45,7 @@ initialize_tdesc_powerpc_7400 (void)
   tdesc_create_reg (feature, "r29", 29, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "r30", 30, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "r31", 31, 1, NULL, 32, "uint32");
-  tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "uint32");
+  tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "code_ptr");
   tdesc_create_reg (feature, "msr", 65, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "cr", 66, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "lr", 67, 1, NULL, 32, "uint32");
Index: features/rs6000/powerpc-750.c
===================================================================
RCS file: /cvs/src/src/gdb/features/rs6000/powerpc-750.c,v
retrieving revision 1.2
diff -u -p -r1.2 powerpc-750.c
--- features/rs6000/powerpc-750.c	5 Nov 2007 21:55:39 -0000	1.2
+++ features/rs6000/powerpc-750.c	4 Feb 2008 21:22:41 -0000
@@ -45,7 +45,7 @@ initialize_tdesc_powerpc_750 (void)
   tdesc_create_reg (feature, "r29", 29, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "r30", 30, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "r31", 31, 1, NULL, 32, "uint32");
-  tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "uint32");
+  tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "code_ptr");
   tdesc_create_reg (feature, "msr", 65, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "cr", 66, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "lr", 67, 1, NULL, 32, "uint32");
Index: features/rs6000/powerpc-860.c
===================================================================
RCS file: /cvs/src/src/gdb/features/rs6000/powerpc-860.c,v
retrieving revision 1.2
diff -u -p -r1.2 powerpc-860.c
--- features/rs6000/powerpc-860.c	5 Nov 2007 21:55:39 -0000	1.2
+++ features/rs6000/powerpc-860.c	4 Feb 2008 21:22:41 -0000
@@ -45,7 +45,7 @@ initialize_tdesc_powerpc_860 (void)
   tdesc_create_reg (feature, "r29", 29, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "r30", 30, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "r31", 31, 1, NULL, 32, "uint32");
-  tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "uint32");
+  tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "code_ptr");
   tdesc_create_reg (feature, "msr", 65, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "cr", 66, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "lr", 67, 1, NULL, 32, "uint32");
Index: features/rs6000/powerpc-e500.c
===================================================================
RCS file: /cvs/src/src/gdb/features/rs6000/powerpc-e500.c,v
retrieving revision 1.2
diff -u -p -r1.2 powerpc-e500.c
--- features/rs6000/powerpc-e500.c	5 Nov 2007 21:55:39 -0000	1.2
+++ features/rs6000/powerpc-e500.c	4 Feb 2008 21:22:41 -0000
@@ -47,7 +47,7 @@ initialize_tdesc_powerpc_e500 (void)
   tdesc_create_reg (feature, "r29", 29, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "r30", 30, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "r31", 31, 1, NULL, 32, "uint32");
-  tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "uint32");
+  tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "code_ptr");
   tdesc_create_reg (feature, "msr", 65, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "cr", 66, 1, NULL, 32, "uint32");
   tdesc_create_reg (feature, "lr", 67, 1, NULL, 32, "uint32");
Index: features/rs6000/rs6000.c
===================================================================
RCS file: /cvs/src/src/gdb/features/rs6000/rs6000.c,v
retrieving revision 1.1
diff -u -p -r1.1 rs6000.c
--- features/rs6000/rs6000.c	15 Oct 2007 19:41:56 -0000	1.1
+++ features/rs6000/rs6000.c	4 Feb 2008 21:22:41 -0000
@@ -47,7 +47,7 @@ initialize_tdesc_rs6000 (void)
   tdesc_create_reg (feature, "r29", 29, 1, NULL, 32, "int");
   tdesc_create_reg (feature, "r30", 30, 1, NULL, 32, "int");
   tdesc_create_reg (feature, "r31", 31, 1, NULL, 32, "int");
-  tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "int");
+  tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "code_ptr");
   tdesc_create_reg (feature, "msr", 65, 1, NULL, 32, "int");
   tdesc_create_reg (feature, "cnd", 66, 1, NULL, 32, "int");
   tdesc_create_reg (feature, "lr", 67, 1, NULL, 32, "int");

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-02-27 20:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-04 21:29 [RFA/ppc] Set PC register type to code_ptr Joel Brobecker
2008-02-04 21:31 ` Joel Brobecker
2008-02-26  3:55 ` Daniel Jacobowitz
2008-02-27 20:28   ` Joel Brobecker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox