From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29836 invoked by alias); 4 Feb 2008 21:29:09 -0000 Received: (qmail 29821 invoked by uid 22791); 4 Feb 2008 21:29:07 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 04 Feb 2008 21:28:40 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 820CD2AA16E for ; Mon, 4 Feb 2008 16:28:38 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id zHOd6aCn9b3r for ; Mon, 4 Feb 2008 16:28:38 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id CBEB42A9E02 for ; Mon, 4 Feb 2008 16:28:37 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 94FF3E7ACB; Mon, 4 Feb 2008 13:28:35 -0800 (PST) Date: Mon, 04 Feb 2008 21:29:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: [RFA/ppc] Set PC register type to code_ptr Message-ID: <20080204212835.GE20922@adacore.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="7JfCtLOvnd9MIVvH" Content-Disposition: inline User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00086.txt.bz2 --7JfCtLOvnd9MIVvH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 1077 Hello, Noticed with the recent testcase that I introduced, "ptype $pc" returns an integer type instead of a pointer to function. Fixed by updating the various XML descriptions and regenerating the associated .c files. 2008-02-04 Joel Brobecker * features/rs6000/power-core.xml, features/rs6000/power64-core.xml features/rs6000/powerpc-601.xml, features/rs6000/rs6000.xml: Set PC register type to "code_ptr". * features/rs6000/powerpc-32.c, features/rs6000/powerpc-403.c, features/rs6000/powerpc-403gc.c, features/rs6000/powerpc-505.c, features/rs6000/powerpc-601.c, features/rs6000/powerpc-602.c, features/rs6000/powerpc-603.c, features/rs6000/powerpc-604.c, features/rs6000/powerpc-64.c, features/rs6000/powerpc-7400.c, features/rs6000/powerpc-750.c, features/rs6000/powerpc-860.c, features/rs6000/powerpc-e500.c, features/rs6000/rs6000.c: Regenerate. Tested on ppc-aix. No regression. Fixes: FAIL: ptype.exp: ptype $pc. OK to apply? Thanks, -- Joel --7JfCtLOvnd9MIVvH Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="features-ppc.diff" Content-length: 15513 Index: features/rs6000/power-core.xml =================================================================== RCS file: /cvs/src/src/gdb/features/rs6000/power-core.xml,v retrieving revision 1.3 diff -u -p -r1.3 power-core.xml --- features/rs6000/power-core.xml 1 Jan 2008 22:53:14 -0000 1.3 +++ features/rs6000/power-core.xml 4 Feb 2008 21:22:40 -0000 @@ -40,7 +40,7 @@ - + Index: features/rs6000/power64-core.xml =================================================================== RCS file: /cvs/src/src/gdb/features/rs6000/power64-core.xml,v retrieving revision 1.3 diff -u -p -r1.3 power64-core.xml --- features/rs6000/power64-core.xml 1 Jan 2008 22:53:14 -0000 1.3 +++ features/rs6000/power64-core.xml 4 Feb 2008 21:22:40 -0000 @@ -40,7 +40,7 @@ - + Index: features/rs6000/powerpc-601.xml =================================================================== RCS file: /cvs/src/src/gdb/features/rs6000/powerpc-601.xml,v retrieving revision 1.2 diff -u -p -r1.2 powerpc-601.xml --- features/rs6000/powerpc-601.xml 1 Jan 2008 22:53:14 -0000 1.2 +++ features/rs6000/powerpc-601.xml 4 Feb 2008 21:22:40 -0000 @@ -46,7 +46,7 @@ - + Index: features/rs6000/rs6000.xml =================================================================== RCS file: /cvs/src/src/gdb/features/rs6000/rs6000.xml,v retrieving revision 1.2 diff -u -p -r1.2 rs6000.xml --- features/rs6000/rs6000.xml 1 Jan 2008 22:53:14 -0000 1.2 +++ features/rs6000/rs6000.xml 4 Feb 2008 21:22:42 -0000 @@ -48,7 +48,7 @@ - + Index: features/rs6000/powerpc-32.c =================================================================== RCS file: /cvs/src/src/gdb/features/rs6000/powerpc-32.c,v retrieving revision 1.2 diff -u -p -r1.2 powerpc-32.c --- features/rs6000/powerpc-32.c 5 Nov 2007 21:55:39 -0000 1.2 +++ features/rs6000/powerpc-32.c 4 Feb 2008 21:22:40 -0000 @@ -47,7 +47,7 @@ initialize_tdesc_powerpc_32 (void) tdesc_create_reg (feature, "r29", 29, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "r30", 30, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "r31", 31, 1, NULL, 32, "uint32"); - tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "uint32"); + tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "code_ptr"); tdesc_create_reg (feature, "msr", 65, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "cr", 66, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "lr", 67, 1, NULL, 32, "uint32"); Index: features/rs6000/powerpc-403.c =================================================================== RCS file: /cvs/src/src/gdb/features/rs6000/powerpc-403.c,v retrieving revision 1.2 diff -u -p -r1.2 powerpc-403.c --- features/rs6000/powerpc-403.c 5 Nov 2007 21:55:39 -0000 1.2 +++ features/rs6000/powerpc-403.c 4 Feb 2008 21:22:40 -0000 @@ -45,7 +45,7 @@ initialize_tdesc_powerpc_403 (void) tdesc_create_reg (feature, "r29", 29, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "r30", 30, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "r31", 31, 1, NULL, 32, "uint32"); - tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "uint32"); + tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "code_ptr"); tdesc_create_reg (feature, "msr", 65, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "cr", 66, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "lr", 67, 1, NULL, 32, "uint32"); Index: features/rs6000/powerpc-403gc.c =================================================================== RCS file: /cvs/src/src/gdb/features/rs6000/powerpc-403gc.c,v retrieving revision 1.2 diff -u -p -r1.2 powerpc-403gc.c --- features/rs6000/powerpc-403gc.c 5 Nov 2007 21:55:39 -0000 1.2 +++ features/rs6000/powerpc-403gc.c 4 Feb 2008 21:22:40 -0000 @@ -45,7 +45,7 @@ initialize_tdesc_powerpc_403gc (void) tdesc_create_reg (feature, "r29", 29, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "r30", 30, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "r31", 31, 1, NULL, 32, "uint32"); - tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "uint32"); + tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "code_ptr"); tdesc_create_reg (feature, "msr", 65, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "cr", 66, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "lr", 67, 1, NULL, 32, "uint32"); Index: features/rs6000/powerpc-505.c =================================================================== RCS file: /cvs/src/src/gdb/features/rs6000/powerpc-505.c,v retrieving revision 1.2 diff -u -p -r1.2 powerpc-505.c --- features/rs6000/powerpc-505.c 5 Nov 2007 21:55:39 -0000 1.2 +++ features/rs6000/powerpc-505.c 4 Feb 2008 21:22:40 -0000 @@ -45,7 +45,7 @@ initialize_tdesc_powerpc_505 (void) tdesc_create_reg (feature, "r29", 29, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "r30", 30, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "r31", 31, 1, NULL, 32, "uint32"); - tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "uint32"); + tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "code_ptr"); tdesc_create_reg (feature, "msr", 65, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "cr", 66, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "lr", 67, 1, NULL, 32, "uint32"); Index: features/rs6000/powerpc-601.c =================================================================== RCS file: /cvs/src/src/gdb/features/rs6000/powerpc-601.c,v retrieving revision 1.1 diff -u -p -r1.1 powerpc-601.c --- features/rs6000/powerpc-601.c 15 Oct 2007 19:41:56 -0000 1.1 +++ features/rs6000/powerpc-601.c 4 Feb 2008 21:22:40 -0000 @@ -45,7 +45,7 @@ initialize_tdesc_powerpc_601 (void) tdesc_create_reg (feature, "r29", 29, 1, NULL, 32, "int"); tdesc_create_reg (feature, "r30", 30, 1, NULL, 32, "int"); tdesc_create_reg (feature, "r31", 31, 1, NULL, 32, "int"); - tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "int"); + tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "code_ptr"); tdesc_create_reg (feature, "msr", 65, 1, NULL, 32, "int"); tdesc_create_reg (feature, "cr", 66, 1, NULL, 32, "int"); tdesc_create_reg (feature, "lr", 67, 1, NULL, 32, "int"); Index: features/rs6000/powerpc-602.c =================================================================== RCS file: /cvs/src/src/gdb/features/rs6000/powerpc-602.c,v retrieving revision 1.2 diff -u -p -r1.2 powerpc-602.c --- features/rs6000/powerpc-602.c 5 Nov 2007 21:55:39 -0000 1.2 +++ features/rs6000/powerpc-602.c 4 Feb 2008 21:22:41 -0000 @@ -45,7 +45,7 @@ initialize_tdesc_powerpc_602 (void) tdesc_create_reg (feature, "r29", 29, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "r30", 30, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "r31", 31, 1, NULL, 32, "uint32"); - tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "uint32"); + tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "code_ptr"); tdesc_create_reg (feature, "msr", 65, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "cr", 66, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "lr", 67, 1, NULL, 32, "uint32"); Index: features/rs6000/powerpc-603.c =================================================================== RCS file: /cvs/src/src/gdb/features/rs6000/powerpc-603.c,v retrieving revision 1.2 diff -u -p -r1.2 powerpc-603.c --- features/rs6000/powerpc-603.c 5 Nov 2007 21:55:39 -0000 1.2 +++ features/rs6000/powerpc-603.c 4 Feb 2008 21:22:41 -0000 @@ -45,7 +45,7 @@ initialize_tdesc_powerpc_603 (void) tdesc_create_reg (feature, "r29", 29, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "r30", 30, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "r31", 31, 1, NULL, 32, "uint32"); - tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "uint32"); + tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "code_ptr"); tdesc_create_reg (feature, "msr", 65, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "cr", 66, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "lr", 67, 1, NULL, 32, "uint32"); Index: features/rs6000/powerpc-604.c =================================================================== RCS file: /cvs/src/src/gdb/features/rs6000/powerpc-604.c,v retrieving revision 1.2 diff -u -p -r1.2 powerpc-604.c --- features/rs6000/powerpc-604.c 5 Nov 2007 21:55:39 -0000 1.2 +++ features/rs6000/powerpc-604.c 4 Feb 2008 21:22:41 -0000 @@ -45,7 +45,7 @@ initialize_tdesc_powerpc_604 (void) tdesc_create_reg (feature, "r29", 29, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "r30", 30, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "r31", 31, 1, NULL, 32, "uint32"); - tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "uint32"); + tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "code_ptr"); tdesc_create_reg (feature, "msr", 65, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "cr", 66, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "lr", 67, 1, NULL, 32, "uint32"); Index: features/rs6000/powerpc-64.c =================================================================== RCS file: /cvs/src/src/gdb/features/rs6000/powerpc-64.c,v retrieving revision 1.2 diff -u -p -r1.2 powerpc-64.c --- features/rs6000/powerpc-64.c 5 Nov 2007 21:55:39 -0000 1.2 +++ features/rs6000/powerpc-64.c 4 Feb 2008 21:22:41 -0000 @@ -47,7 +47,7 @@ initialize_tdesc_powerpc_64 (void) tdesc_create_reg (feature, "r29", 29, 1, NULL, 64, "uint64"); tdesc_create_reg (feature, "r30", 30, 1, NULL, 64, "uint64"); tdesc_create_reg (feature, "r31", 31, 1, NULL, 64, "uint64"); - tdesc_create_reg (feature, "pc", 64, 1, NULL, 64, "uint64"); + tdesc_create_reg (feature, "pc", 64, 1, NULL, 64, "code_ptr"); tdesc_create_reg (feature, "msr", 65, 1, NULL, 64, "uint64"); tdesc_create_reg (feature, "cr", 66, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "lr", 67, 1, NULL, 64, "uint64"); Index: features/rs6000/powerpc-7400.c =================================================================== RCS file: /cvs/src/src/gdb/features/rs6000/powerpc-7400.c,v retrieving revision 1.2 diff -u -p -r1.2 powerpc-7400.c --- features/rs6000/powerpc-7400.c 5 Nov 2007 21:55:39 -0000 1.2 +++ features/rs6000/powerpc-7400.c 4 Feb 2008 21:22:41 -0000 @@ -45,7 +45,7 @@ initialize_tdesc_powerpc_7400 (void) tdesc_create_reg (feature, "r29", 29, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "r30", 30, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "r31", 31, 1, NULL, 32, "uint32"); - tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "uint32"); + tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "code_ptr"); tdesc_create_reg (feature, "msr", 65, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "cr", 66, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "lr", 67, 1, NULL, 32, "uint32"); Index: features/rs6000/powerpc-750.c =================================================================== RCS file: /cvs/src/src/gdb/features/rs6000/powerpc-750.c,v retrieving revision 1.2 diff -u -p -r1.2 powerpc-750.c --- features/rs6000/powerpc-750.c 5 Nov 2007 21:55:39 -0000 1.2 +++ features/rs6000/powerpc-750.c 4 Feb 2008 21:22:41 -0000 @@ -45,7 +45,7 @@ initialize_tdesc_powerpc_750 (void) tdesc_create_reg (feature, "r29", 29, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "r30", 30, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "r31", 31, 1, NULL, 32, "uint32"); - tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "uint32"); + tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "code_ptr"); tdesc_create_reg (feature, "msr", 65, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "cr", 66, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "lr", 67, 1, NULL, 32, "uint32"); Index: features/rs6000/powerpc-860.c =================================================================== RCS file: /cvs/src/src/gdb/features/rs6000/powerpc-860.c,v retrieving revision 1.2 diff -u -p -r1.2 powerpc-860.c --- features/rs6000/powerpc-860.c 5 Nov 2007 21:55:39 -0000 1.2 +++ features/rs6000/powerpc-860.c 4 Feb 2008 21:22:41 -0000 @@ -45,7 +45,7 @@ initialize_tdesc_powerpc_860 (void) tdesc_create_reg (feature, "r29", 29, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "r30", 30, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "r31", 31, 1, NULL, 32, "uint32"); - tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "uint32"); + tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "code_ptr"); tdesc_create_reg (feature, "msr", 65, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "cr", 66, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "lr", 67, 1, NULL, 32, "uint32"); Index: features/rs6000/powerpc-e500.c =================================================================== RCS file: /cvs/src/src/gdb/features/rs6000/powerpc-e500.c,v retrieving revision 1.2 diff -u -p -r1.2 powerpc-e500.c --- features/rs6000/powerpc-e500.c 5 Nov 2007 21:55:39 -0000 1.2 +++ features/rs6000/powerpc-e500.c 4 Feb 2008 21:22:41 -0000 @@ -47,7 +47,7 @@ initialize_tdesc_powerpc_e500 (void) tdesc_create_reg (feature, "r29", 29, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "r30", 30, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "r31", 31, 1, NULL, 32, "uint32"); - tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "uint32"); + tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "code_ptr"); tdesc_create_reg (feature, "msr", 65, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "cr", 66, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "lr", 67, 1, NULL, 32, "uint32"); Index: features/rs6000/rs6000.c =================================================================== RCS file: /cvs/src/src/gdb/features/rs6000/rs6000.c,v retrieving revision 1.1 diff -u -p -r1.1 rs6000.c --- features/rs6000/rs6000.c 15 Oct 2007 19:41:56 -0000 1.1 +++ features/rs6000/rs6000.c 4 Feb 2008 21:22:41 -0000 @@ -47,7 +47,7 @@ initialize_tdesc_rs6000 (void) tdesc_create_reg (feature, "r29", 29, 1, NULL, 32, "int"); tdesc_create_reg (feature, "r30", 30, 1, NULL, 32, "int"); tdesc_create_reg (feature, "r31", 31, 1, NULL, 32, "int"); - tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "int"); + tdesc_create_reg (feature, "pc", 64, 1, NULL, 32, "code_ptr"); tdesc_create_reg (feature, "msr", 65, 1, NULL, 32, "int"); tdesc_create_reg (feature, "cnd", 66, 1, NULL, 32, "int"); tdesc_create_reg (feature, "lr", 67, 1, NULL, 32, "int"); --7JfCtLOvnd9MIVvH--