From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: Re: [RFC/RFA] handle function homonyms in breakpoint expressions
Date: Tue, 29 Jan 2008 18:09:00 -0000 [thread overview]
Message-ID: <20080129180757.GJ3773@caradoc.them.org> (raw)
In-Reply-To: <20080102104506.GC15903@adacore.com>
On Wed, Jan 02, 2008 at 02:45:06AM -0800, Joel Brobecker wrote:
> > The idea is to short-circuit the end of decode_line_1 and call the
> > Ada-specific part instead, like so:
> >
> > else if (current_language->la_language == language_ada)
> > {
> > return ada_finish_decode_line_1 (argptr, file_symtab, funfirstline,
> > canonical, not_found_ptr);
> > }
>
> Actually, I forgot one small piece. Inside linespec.c:locate_first_half,
> we need to do handle the parsing a little bit differently for Ada.
> This is because we re-write the breakpoint location expression in
> a canonical form that is unambiguous. For that, we use the form
> FILE:FUN_NAME:LINE_NO. As a result, the parsing needs to be adjusted
> for Ada. We do this by adding the following code in locate_first_half:
Grumble, if this form is better for Ada, is it better for everyone
else too?
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-01-29 18:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-01 19:47 Joel Brobecker
2008-01-02 10:50 ` Joel Brobecker
2008-01-29 18:09 ` Daniel Jacobowitz [this message]
2008-01-29 17:40 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080129180757.GJ3773@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox