From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28792 invoked by alias); 29 Jan 2008 18:08:20 -0000 Received: (qmail 28780 invoked by uid 22791); 29 Jan 2008 18:08:20 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 29 Jan 2008 18:07:59 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id E4EA098151 for ; Tue, 29 Jan 2008 18:07:57 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id C9EEF9811F for ; Tue, 29 Jan 2008 18:07:57 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1JJusH-0001hr-1B for gdb-patches@sourceware.org; Tue, 29 Jan 2008 13:07:57 -0500 Date: Tue, 29 Jan 2008 18:09:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: [RFC/RFA] handle function homonyms in breakpoint expressions Message-ID: <20080129180757.GJ3773@caradoc.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <20080101194709.GB3758@adacore.com> <20080102104506.GC15903@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080102104506.GC15903@adacore.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00706.txt.bz2 On Wed, Jan 02, 2008 at 02:45:06AM -0800, Joel Brobecker wrote: > > The idea is to short-circuit the end of decode_line_1 and call the > > Ada-specific part instead, like so: > > > > else if (current_language->la_language == language_ada) > > { > > return ada_finish_decode_line_1 (argptr, file_symtab, funfirstline, > > canonical, not_found_ptr); > > } > > Actually, I forgot one small piece. Inside linespec.c:locate_first_half, > we need to do handle the parsing a little bit differently for Ada. > This is because we re-write the breakpoint location expression in > a canonical form that is unambiguous. For that, we use the form > FILE:FUN_NAME:LINE_NO. As a result, the parsing needs to be adjusted > for Ada. We do this by adding the following code in locate_first_half: Grumble, if this form is better for Ada, is it better for everyone else too? -- Daniel Jacobowitz CodeSourcery