Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC/RFA] handle function homonyms in breakpoint expressions
Date: Tue, 29 Jan 2008 17:40:00 -0000	[thread overview]
Message-ID: <20080129173536.GB3773@caradoc.them.org> (raw)
In-Reply-To: <20080101194709.GB3758@adacore.com>

On Tue, Jan 01, 2008 at 11:47:09AM -0800, Joel Brobecker wrote:
> Hello,
> 
> The problem I am trying to fix is the following. Imagine we have
> the following two functions defined:
> 
>     procedure Next (I : in out Integer);
>     procedure Next (F : in out Float);
> 
> If the user tries to break on "Next", then the expression is ambiguous
> and GDB should present a multiple-choice menu and ask the user to choose:
> 
>     (gdb) b next
>     [0] cancel
>     [1] all
>     [2] pck.next at pck.adb:5
>     [3] pck.next at pck.adb:10

AKA exactly the same as C++ overloaded functions, which are already
handled by the generic code.  I wish Ada didn't need its own copy of
the menu printing code - this (practical, I admit) habit of fixing
infrastructure issues in ada-lang.c make it already the largest source
file in GDB and getting larger.  It's got a good chunk of symtab.c
reimplemented already.

Again, this is the status quo, so I'm not going to rain on the
parade.  But in the long term this is a horrible maintenance mess.

-- 
Daniel Jacobowitz
CodeSourcery


      parent reply	other threads:[~2008-01-29 17:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-01 19:47 Joel Brobecker
2008-01-02 10:50 ` Joel Brobecker
2008-01-29 18:09   ` Daniel Jacobowitz
2008-01-29 17:40 ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080129173536.GB3773@caradoc.them.org \
    --to=drow@false.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox