From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Jerome Guitton <guitton@adacore.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFA] backtrace in mixed language applications (take 2)
Date: Tue, 29 Jan 2008 18:06:00 -0000 [thread overview]
Message-ID: <20080129180025.GH3773@caradoc.them.org> (raw)
In-Reply-To: <20080109204712.GJ21281@adacore.com>
On Wed, Jan 09, 2008 at 12:47:12PM -0800, Joel Brobecker wrote:
> @@ -366,7 +366,8 @@ print_frame_args (struct symbol *func, s
> if (val)
> {
> common_val_print (val, stb->stream, 0, 0, 2,
> - Val_no_prettyprint);
> + Val_no_prettyprint,
> + language_def (SYMBOL_LANGUAGE (sym)));
> ui_out_field_stream (uiout, "value", stb);
> }
> else
The patch looks sane to me, except for this, which ignores "set
language" - compare to the code in select_frame. Do you think we
ought to honor it here if it's been set?
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-01-29 18:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-10 10:03 [RFA] backtrace in mixed language applications Jerome Guitton
2007-08-15 19:14 ` Joel Brobecker
2007-08-15 19:29 ` Daniel Jacobowitz
2007-09-17 11:28 ` Jerome Guitton
2008-01-09 20:48 ` [RFA] backtrace in mixed language applications (take 2) Joel Brobecker
2008-01-29 18:06 ` Daniel Jacobowitz [this message]
2008-02-04 20:56 ` Joel Brobecker
2008-02-04 21:04 ` Joel Brobecker
2008-04-24 2:15 ` Joel Brobecker
2008-05-01 19:48 ` Daniel Jacobowitz
2008-05-07 11:36 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080129180025.GH3773@caradoc.them.org \
--to=drow@false.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sources.redhat.com \
--cc=guitton@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox