Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Jerome Guitton <guitton@adacore.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFA] backtrace in mixed language applications (take 2)
Date: Mon, 04 Feb 2008 20:56:00 -0000	[thread overview]
Message-ID: <20080204205620.GE21614@adacore.com> (raw)
In-Reply-To: <20080129180025.GH3773@caradoc.them.org>

> >  		  common_val_print (val, stb->stream, 0, 0, 2,
> > -				    Val_no_prettyprint);
> > +				    Val_no_prettyprint,
> > +				    language_def (SYMBOL_LANGUAGE (sym)));
> >  		  ui_out_field_stream (uiout, "value", stb);
> >  	        }
> >  	      else
> 
> The patch looks sane to me, except for this, which ignores "set
> language" - compare to the code in select_frame.  Do you think we
> ought to honor it here if it's been set?

Good catch.  I don't have any clear reason why we should change
the previous behavior in this case, so I've tweaked the previous
patch to honor "set language". I also added a test in the new
testcase to verify this. The rest of the patch should be identical.

2008-02-04  Joel Brobecker  <brobecker@adacore.com>

        * valprint.c (val_print): Add new language parameter and use it
        instead of using the current_language. Update calls to val_print
        throughout.
        (common_val_print): Add new langauge parameter and pass it to
        val_print.
        * value.h (struct language_defn): Add opaque declaration.
        (val_print, common_val_print): Update declarations.
        * stack.c (print_frame_args): Update call to common_val_print
        using the appropriate language.
        * mi/mi-cmd-stack.c (list_args_or_locals): Likewise.
        * c-valprint, f-valprint.c, m2-valprint.c, mt-tdep.c, infcmd.c,
        mi/mi-main.c, jv-valprint.c, ada-valprint.c, varobj.c, p-valprint.c,
        scm-valprint.c, cp-valprint.c, sh64-tdep.c, printcmd.c:
        #include "language.h" if necessary.
        Update calls to val_print and common_val_print.
        * Makefile.in (mt-tdep.o, sh64-tdep.o, mi-cmds.o, mi-main.o):
        Update dependencies.

2008-02-04  Jerome Guitton  <guitton@adacore.com>
            Joel Brobecker  <brobecker@adacore.com>

        * gdb.ada/lang_switch: New test program.
        * gdb.ada/lang_switch.exp: New testcase.

Tested on x86-linux. No regression.
OK to apply?

Thanks,
-- 
Joel


  reply	other threads:[~2008-02-04 20:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-10 10:03 [RFA] backtrace in mixed language applications Jerome Guitton
2007-08-15 19:14 ` Joel Brobecker
2007-08-15 19:29   ` Daniel Jacobowitz
2007-09-17 11:28 ` Jerome Guitton
2008-01-09 20:48 ` [RFA] backtrace in mixed language applications (take 2) Joel Brobecker
2008-01-29 18:06   ` Daniel Jacobowitz
2008-02-04 20:56     ` Joel Brobecker [this message]
2008-02-04 21:04       ` Joel Brobecker
2008-04-24  2:15         ` Joel Brobecker
2008-05-01 19:48           ` Daniel Jacobowitz
2008-05-07 11:36             ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080204205620.GE21614@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=guitton@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox