From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18419 invoked by alias); 29 Jan 2008 18:00:48 -0000 Received: (qmail 18410 invoked by uid 22791); 29 Jan 2008 18:00:47 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 29 Jan 2008 18:00:28 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 7FF1098151; Tue, 29 Jan 2008 18:00:26 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 5E5E79811F; Tue, 29 Jan 2008 18:00:26 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1JJukz-0001YA-KD; Tue, 29 Jan 2008 13:00:25 -0500 Date: Tue, 29 Jan 2008 18:06:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: Jerome Guitton , gdb-patches@sources.redhat.com Subject: Re: [RFA] backtrace in mixed language applications (take 2) Message-ID: <20080129180025.GH3773@caradoc.them.org> Mail-Followup-To: Joel Brobecker , Jerome Guitton , gdb-patches@sources.redhat.com References: <20070810100313.GA29799@adacore.com> <20080109204712.GJ21281@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080109204712.GJ21281@adacore.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00704.txt.bz2 On Wed, Jan 09, 2008 at 12:47:12PM -0800, Joel Brobecker wrote: > @@ -366,7 +366,8 @@ print_frame_args (struct symbol *func, s > if (val) > { > common_val_print (val, stb->stream, 0, 0, 2, > - Val_no_prettyprint); > + Val_no_prettyprint, > + language_def (SYMBOL_LANGUAGE (sym))); > ui_out_field_stream (uiout, "value", stb); > } > else The patch looks sane to me, except for this, which ignores "set language" - compare to the code in select_frame. Do you think we ought to honor it here if it's been set? -- Daniel Jacobowitz CodeSourcery