[RFA] make gdb.base/sigall.c more robust

[RFA] make gdb.base/sigall.c more robust

[Doug Evans]

One environment in which I run the gdb testsuite has a few signals blocked
at the start.  If tcl/expect/bash had the ability to unblock signals it might
be preferable to unblock the signals there (I couldn't find any),
but OTOH testcases should be reasonably robust.

2008-01-17  Doug Evans  <dje@google.com>

	* gdb.base/sigall.c (main): Ensure all signals aren't blocked.

Index: sigall.c
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/sigall.c,v
retrieving revision 1.1.1.2
diff -u -p -u -p -r1.1.1.2 sigall.c
--- sigall.c	28 Jun 1999 16:04:02 -0000	1.1.1.2
+++ sigall.c	17 Jan 2008 23:18:55 -0000
@@ -1581,6 +1581,18 @@ main ()
   set_debug_traps ();
   breakpoint ();
 #endif
+
+#ifdef SIG_SETMASK
+  /* Ensure all the signals aren't blocked.
+     The environment in which the testsuite is run may have blocked some
+     for whatever reason.  */
+  {
+    sigset_t newset;
+    sigemptyset (&newset);
+    sigprocmask (SIG_SETMASK, &newset, NULL);
+  }
+#endif
+
   signal (SIGABRT, handle_ABRT);
 #ifdef SIGHUP
   signal (SIGHUP, handle_HUP);

Re: [RFA] make gdb.base/sigall.c more robust

[Doug Evans]

Ping ...

On Jan 17, 2008 3:31 PM, Doug Evans <dje@google.com> wrote:
> One environment in which I run the gdb testsuite has a few signals blocked
> at the start.  If tcl/expect/bash had the ability to unblock signals it might
> be preferable to unblock the signals there (I couldn't find any),
> but OTOH testcases should be reasonably robust.
>
> 2008-01-17  Doug Evans  <dje@google.com>
>
>         * gdb.base/sigall.c (main): Ensure all signals aren't blocked.
>
> Index: sigall.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/sigall.c,v
> retrieving revision 1.1.1.2
> diff -u -p -u -p -r1.1.1.2 sigall.c
> --- sigall.c    28 Jun 1999 16:04:02 -0000      1.1.1.2
> +++ sigall.c    17 Jan 2008 23:18:55 -0000
> @@ -1581,6 +1581,18 @@ main ()
>    set_debug_traps ();
>    breakpoint ();
>  #endif
> +
> +#ifdef SIG_SETMASK
> +  /* Ensure all the signals aren't blocked.
> +     The environment in which the testsuite is run may have blocked some
> +     for whatever reason.  */
> +  {
> +    sigset_t newset;
> +    sigemptyset (&newset);
> +    sigprocmask (SIG_SETMASK, &newset, NULL);
> +  }
> +#endif
> +
>    signal (SIGABRT, handle_ABRT);
>  #ifdef SIGHUP
>    signal (SIGHUP, handle_HUP);
>

Re: [RFA] make gdb.base/sigall.c more robust

[Daniel Jacobowitz]

On Thu, Jan 17, 2008 at 03:31:41PM -0800, Doug Evans wrote:
> One environment in which I run the gdb testsuite has a few signals blocked
> at the start.  If tcl/expect/bash had the ability to unblock signals it might
> be preferable to unblock the signals there (I couldn't find any),
> but OTOH testcases should be reasonably robust.
> 
> 2008-01-17  Doug Evans  <dje@google.com>
> 
> 	* gdb.base/sigall.c (main): Ensure all signals aren't blocked.

OK.

-- 
Daniel Jacobowitz
CodeSourcery