From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 449 invoked by alias); 28 Jan 2008 23:48:38 -0000 Received: (qmail 437 invoked by uid 22791); 28 Jan 2008 23:48:38 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 28 Jan 2008 23:48:21 +0000 Received: from zps76.corp.google.com (zps76.corp.google.com [172.25.146.76]) by smtp-out.google.com with ESMTP id m0SNmGFe010725 for ; Mon, 28 Jan 2008 15:48:16 -0800 Received: from rv-out-0910.google.com (rvbk20.prod.google.com [10.140.87.20]) by zps76.corp.google.com with ESMTP id m0SNk8cs015462 for ; Mon, 28 Jan 2008 15:48:16 -0800 Received: by rv-out-0910.google.com with SMTP id k20so1472373rvb.33 for ; Mon, 28 Jan 2008 15:48:16 -0800 (PST) Received: by 10.141.156.19 with SMTP id i19mr3897702rvo.57.1201564096429; Mon, 28 Jan 2008 15:48:16 -0800 (PST) Received: by 10.141.186.16 with HTTP; Mon, 28 Jan 2008 15:48:16 -0800 (PST) Message-ID: Date: Mon, 28 Jan 2008 23:51:00 -0000 From: "Doug Evans" To: gdb-patches@sourceware.org Subject: Re: [RFA] make gdb.base/sigall.c more robust In-Reply-To: <20080117233141.5FAA51C7247@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080117233141.5FAA51C7247@localhost> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00657.txt.bz2 Ping ... On Jan 17, 2008 3:31 PM, Doug Evans wrote: > One environment in which I run the gdb testsuite has a few signals blocked > at the start. If tcl/expect/bash had the ability to unblock signals it might > be preferable to unblock the signals there (I couldn't find any), > but OTOH testcases should be reasonably robust. > > 2008-01-17 Doug Evans > > * gdb.base/sigall.c (main): Ensure all signals aren't blocked. > > Index: sigall.c > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/sigall.c,v > retrieving revision 1.1.1.2 > diff -u -p -u -p -r1.1.1.2 sigall.c > --- sigall.c 28 Jun 1999 16:04:02 -0000 1.1.1.2 > +++ sigall.c 17 Jan 2008 23:18:55 -0000 > @@ -1581,6 +1581,18 @@ main () > set_debug_traps (); > breakpoint (); > #endif > + > +#ifdef SIG_SETMASK > + /* Ensure all the signals aren't blocked. > + The environment in which the testsuite is run may have blocked some > + for whatever reason. */ > + { > + sigset_t newset; > + sigemptyset (&newset); > + sigprocmask (SIG_SETMASK, &newset, NULL); > + } > +#endif > + > signal (SIGABRT, handle_ABRT); > #ifdef SIGHUP > signal (SIGHUP, handle_HUP); >