From: Daniel Jacobowitz <drow@false.org>
To: Luis Machado <luisgpm@linux.vnet.ibm.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Improve printf DFP support
Date: Wed, 09 Jan 2008 12:52:00 -0000 [thread overview]
Message-ID: <20080109125212.GD27746@caradoc.them.org> (raw)
In-Reply-To: <1199837025.22083.13.camel@gargoyle>
On Tue, Jan 08, 2008 at 10:03:44PM -0200, Luis Machado wrote:
> 2008-08-01 Luis Machado <luisgpm@br.ibm.com>
>
> * printcmd.c (printf_command): Add seen_big_h, seen_big_d and
> seen_double_big_d, treat the new H, D, and DD modifiers as length
> modifiers.
> * doc/gdb.texinfo (Output): Update documentation on using printf with DFP
> types.
> * testsuite/gdb.base/printcmds.exp (test_printf_with_dfp): Update
> printf calls with required float modifiers.
OK. Remember that doc/ and testsuite/ entries go into their own
changelogs. Also, please be careful with spaces versus tabs. I see a
lot of strange indentation in this patch.
> + /* Check for a Decimal128. */
> + if (*f == 'D')
> + {
Here, for instance.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-01-09 12:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 13:28 Luis Machado
2008-01-08 15:19 ` Thiago Jung Bauermann
2008-01-08 15:29 ` Luis Machado
2008-01-08 15:29 ` Daniel Jacobowitz
2008-01-08 23:54 ` Jim Blandy
2008-01-08 20:42 ` Eli Zaretskii
2008-01-09 0:04 ` Luis Machado
2008-01-09 4:14 ` Eli Zaretskii
2008-01-09 12:52 ` Daniel Jacobowitz [this message]
2008-01-09 13:51 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080109125212.GD27746@caradoc.them.org \
--to=drow@false.org \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=luisgpm@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox