From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3137 invoked by alias); 9 Jan 2008 12:52:35 -0000 Received: (qmail 3126 invoked by uid 22791); 9 Jan 2008 12:52:35 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 09 Jan 2008 12:52:15 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 1FA40982E2; Wed, 9 Jan 2008 12:52:14 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id C8EE198216; Wed, 9 Jan 2008 12:52:13 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1JCaPk-0007Nq-Q1; Wed, 09 Jan 2008 07:52:12 -0500 Date: Wed, 09 Jan 2008 12:52:00 -0000 From: Daniel Jacobowitz To: Luis Machado Cc: Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: [PATCH] Improve printf DFP support Message-ID: <20080109125212.GD27746@caradoc.them.org> Mail-Followup-To: Luis Machado , Eli Zaretskii , gdb-patches@sourceware.org References: <1199798856.22083.9.camel@gargoyle> <1199837025.22083.13.camel@gargoyle> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1199837025.22083.13.camel@gargoyle> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00183.txt.bz2 On Tue, Jan 08, 2008 at 10:03:44PM -0200, Luis Machado wrote: > 2008-08-01 Luis Machado > > * printcmd.c (printf_command): Add seen_big_h, seen_big_d and > seen_double_big_d, treat the new H, D, and DD modifiers as length > modifiers. > * doc/gdb.texinfo (Output): Update documentation on using printf with DFP > types. > * testsuite/gdb.base/printcmds.exp (test_printf_with_dfp): Update > printf calls with required float modifiers. OK. Remember that doc/ and testsuite/ entries go into their own changelogs. Also, please be careful with spaces versus tabs. I see a lot of strange indentation in this patch. > + /* Check for a Decimal128. */ > + if (*f == 'D') > + { Here, for instance. -- Daniel Jacobowitz CodeSourcery