From: Daniel Jacobowitz <drow@false.org>
To: Thiago Jung Bauermann <bauerman@br.ibm.com>
Cc: luisgpm@linux.vnet.ibm.com, gdb-patches@sourceware.org
Subject: Re: [PATCH] Improve printf DFP support
Date: Tue, 08 Jan 2008 15:29:00 -0000 [thread overview]
Message-ID: <20080108152919.GA21337@caradoc.them.org> (raw)
In-Reply-To: <1199805546.15225.8.camel@localhost.localdomain>
On Tue, Jan 08, 2008 at 01:19:06PM -0200, Thiago Jung Bauermann wrote:
> param_ptr should be a const gdb_byte *, and the cast here should be
> removed. In addition, I believe the use of value_offset here is wrong.
> Other uses of value_offset are to obtain a memory address in the
> inferior address space, not in GDB's. Also, I think that value_contents
> should be used intead of value_contents_all so that the value's
> embedded_offset can be taken into account.
I believe that you are correct. The value handling is another area of
GDB that could do with some cleaning up; I am not convinced the
multiple offsets dance is necessary...
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-01-08 15:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 13:28 Luis Machado
2008-01-08 15:19 ` Thiago Jung Bauermann
2008-01-08 15:29 ` Luis Machado
2008-01-08 15:29 ` Daniel Jacobowitz [this message]
2008-01-08 23:54 ` Jim Blandy
2008-01-08 20:42 ` Eli Zaretskii
2008-01-09 0:04 ` Luis Machado
2008-01-09 4:14 ` Eli Zaretskii
2008-01-09 12:52 ` Daniel Jacobowitz
2008-01-09 13:51 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080108152919.GA21337@caradoc.them.org \
--to=drow@false.org \
--cc=bauerman@br.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=luisgpm@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox