From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24342 invoked by alias); 8 Jan 2008 15:29:49 -0000 Received: (qmail 24332 invoked by uid 22791); 8 Jan 2008 15:29:49 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 08 Jan 2008 15:29:23 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 3164498216; Tue, 8 Jan 2008 15:29:21 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 0E0E398022; Tue, 8 Jan 2008 15:29:21 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1JCGOF-0005bb-D7; Tue, 08 Jan 2008 10:29:19 -0500 Date: Tue, 08 Jan 2008 15:29:00 -0000 From: Daniel Jacobowitz To: Thiago Jung Bauermann Cc: luisgpm@linux.vnet.ibm.com, gdb-patches@sourceware.org Subject: Re: [PATCH] Improve printf DFP support Message-ID: <20080108152919.GA21337@caradoc.them.org> Mail-Followup-To: Thiago Jung Bauermann , luisgpm@linux.vnet.ibm.com, gdb-patches@sourceware.org References: <1199798856.22083.9.camel@gargoyle> <1199805546.15225.8.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1199805546.15225.8.camel@localhost.localdomain> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00134.txt.bz2 On Tue, Jan 08, 2008 at 01:19:06PM -0200, Thiago Jung Bauermann wrote: > param_ptr should be a const gdb_byte *, and the cast here should be > removed. In addition, I believe the use of value_offset here is wrong. > Other uses of value_offset are to obtain a memory address in the > inferior address space, not in GDB's. Also, I think that value_contents > should be used intead of value_contents_all so that the value's > embedded_offset can be taken into account. I believe that you are correct. The value handling is another area of GDB that could do with some cleaning up; I am not convinced the multiple offsets dance is necessary... -- Daniel Jacobowitz CodeSourcery