[RFA] Remove #include defs.h in nto-tdep.h

[RFA] Remove #include defs.h in nto-tdep.h

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 426 bytes --]

Hello,

I wouldn't mind an extra pair of eyes, given my track record in the
past patches :-/.

2007-12-20  Joel Brobecker  <brobecker@adacore.com>

        * nto-tdep.h: Remove #include "defs.h".
        * nto-tdep.c: Add #include "defs.h".
        * Makefile.in (nto_tdep_h): Update dependencies.
        (nto-tdep.o): Likewise.

Tested on x86-linux by recompiling nto-tdep.c and i386-nto-tdep.c.
Looks OK?

Thanks,
-- 
Joel

[-- Attachment #2: nto-defs.diff --]
[-- Type: text/plain, Size: 2224 bytes --]

Index: nto-tdep.h
===================================================================
RCS file: /cvs/src/src/gdb/nto-tdep.h,v
retrieving revision 1.7
diff -u -p -r1.7 nto-tdep.h
--- nto-tdep.h	23 Aug 2007 18:08:36 -0000	1.7
+++ nto-tdep.h	20 Dec 2007 05:47:29 -0000
@@ -22,7 +22,6 @@
 #ifndef _NTO_TDEP_H
 #define _NTO_TDEP_H
 
-#include "defs.h"
 #include "solist.h"
 #include "osabi.h"
 #include "regset.h"
Index: nto-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/nto-tdep.c,v
retrieving revision 1.22
diff -u -p -r1.22 nto-tdep.c
--- nto-tdep.c	17 Nov 2007 00:55:28 -0000	1.22
+++ nto-tdep.c	20 Dec 2007 05:47:30 -0000
@@ -19,6 +19,7 @@
    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
+#include "defs.h"
 #include "gdb_stat.h"
 #include "gdb_string.h"
 #include "nto-tdep.h"
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.968
diff -u -p -r1.968 Makefile.in
--- Makefile.in	20 Dec 2007 05:36:14 -0000	1.968
+++ Makefile.in	20 Dec 2007 05:47:42 -0000
@@ -838,7 +838,7 @@ mn10300_tdep_h = mn10300-tdep.h
 monitor_h = monitor.h
 nbsd_nat_h = nbsd-nat.h
 nbsd_tdep_h = nbsd-tdep.h
-nto_tdep_h = nto-tdep.h $(defs_h) $(solist_h) $(osabi_h) $(regset_h)
+nto_tdep_h = nto-tdep.h $(solist_h) $(osabi_h) $(regset_h)
 objc_lang_h = objc-lang.h
 objfiles_h = objfiles.h $(gdb_obstack_h) $(symfile_h)
 obsd_tdep_h = obsd-tdep.h
@@ -2509,7 +2509,8 @@ nbsd-tdep.o: nbsd-tdep.c $(defs_h) $(gdb
 nto-procfs.o: nto-procfs.c $(defs_h) $(gdb_dirent_h) $(exceptions_h) \
 	$(gdb_string_h) $(gdbcore_h) $(inferior_h) $(target_h) $(objfiles_h) \
 	$(gdbthread_h) $(nto_tdep_h) $(command_h) $(regcache_h) $(solib_h)
-nto-tdep.o: nto-tdep.c $(gdb_stat_h) $(gdb_string_h) $(nto_tdep_h) $(top_h) \
+nto-tdep.o: nto-tdep.c $(defs_h) $(gdb_stat_h) $(gdb_string_h) $(nto_tdep_h) \
+	$(top_h) \
 	$(cli_decode_h) $(cli_cmds_h) $(inferior_h) $(gdbarch_h) $(bfd_h) \
 	$(elf_bfd_h) $(solib_svr4_h) $(gdbcore_h) $(objfiles_h)
 objc-exp.o: objc-exp.c $(defs_h) $(gdb_string_h) $(expression_h) \

Re: [RFA] Remove #include defs.h in nto-tdep.h

[Daniel Jacobowitz]

On Thu, Dec 20, 2007 at 09:51:44AM +0400, Joel Brobecker wrote:
> Hello,
> 
> I wouldn't mind an extra pair of eyes, given my track record in the
> past patches :-/.
> 
> 2007-12-20  Joel Brobecker  <brobecker@adacore.com>
> 
>         * nto-tdep.h: Remove #include "defs.h".
>         * nto-tdep.c: Add #include "defs.h".
>         * Makefile.in (nto_tdep_h): Update dependencies.
>         (nto-tdep.o): Likewise.
> 
> Tested on x86-linux by recompiling nto-tdep.c and i386-nto-tdep.c.
> Looks OK?

OK.

-- 
Daniel Jacobowitz
CodeSourcery

Re: [RFA] Remove #include defs.h in nto-tdep.h

[Joel Brobecker]

> > 2007-12-20  Joel Brobecker  <brobecker@adacore.com>
> > 
> >         * nto-tdep.h: Remove #include "defs.h".
> >         * nto-tdep.c: Add #include "defs.h".
> >         * Makefile.in (nto_tdep_h): Update dependencies.
> >         (nto-tdep.o): Likewise.
> > 
> > Tested on x86-linux by recompiling nto-tdep.c and i386-nto-tdep.c.
> > Looks OK?
> 
> OK.

Thanks, Daniel. This one is in.

-- 
Joel