From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32374 invoked by alias); 20 Dec 2007 05:52:02 -0000 Received: (qmail 32322 invoked by uid 22791); 20 Dec 2007 05:52:01 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 20 Dec 2007 05:51:55 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D30D02A967D for ; Thu, 20 Dec 2007 00:51:53 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id QgVNQY4urZPK for ; Thu, 20 Dec 2007 00:51:53 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id BF5F02A9679 for ; Thu, 20 Dec 2007 00:51:52 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 3AB55E7ACA; Thu, 20 Dec 2007 09:51:44 +0400 (RET) Date: Thu, 20 Dec 2007 05:55:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: [RFA] Remove #include defs.h in nto-tdep.h Message-ID: <20071220055144.GG6154@adacore.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="X3gaHHMYHkYqP6yf" Content-Disposition: inline User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00329.txt.bz2 --X3gaHHMYHkYqP6yf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 426 Hello, I wouldn't mind an extra pair of eyes, given my track record in the past patches :-/. 2007-12-20 Joel Brobecker * nto-tdep.h: Remove #include "defs.h". * nto-tdep.c: Add #include "defs.h". * Makefile.in (nto_tdep_h): Update dependencies. (nto-tdep.o): Likewise. Tested on x86-linux by recompiling nto-tdep.c and i386-nto-tdep.c. Looks OK? Thanks, -- Joel --X3gaHHMYHkYqP6yf Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="nto-defs.diff" Content-length: 2224 Index: nto-tdep.h =================================================================== RCS file: /cvs/src/src/gdb/nto-tdep.h,v retrieving revision 1.7 diff -u -p -r1.7 nto-tdep.h --- nto-tdep.h 23 Aug 2007 18:08:36 -0000 1.7 +++ nto-tdep.h 20 Dec 2007 05:47:29 -0000 @@ -22,7 +22,6 @@ #ifndef _NTO_TDEP_H #define _NTO_TDEP_H -#include "defs.h" #include "solist.h" #include "osabi.h" #include "regset.h" Index: nto-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/nto-tdep.c,v retrieving revision 1.22 diff -u -p -r1.22 nto-tdep.c --- nto-tdep.c 17 Nov 2007 00:55:28 -0000 1.22 +++ nto-tdep.c 20 Dec 2007 05:47:30 -0000 @@ -19,6 +19,7 @@ You should have received a copy of the GNU General Public License along with this program. If not, see . */ +#include "defs.h" #include "gdb_stat.h" #include "gdb_string.h" #include "nto-tdep.h" Index: Makefile.in =================================================================== RCS file: /cvs/src/src/gdb/Makefile.in,v retrieving revision 1.968 diff -u -p -r1.968 Makefile.in --- Makefile.in 20 Dec 2007 05:36:14 -0000 1.968 +++ Makefile.in 20 Dec 2007 05:47:42 -0000 @@ -838,7 +838,7 @@ mn10300_tdep_h = mn10300-tdep.h monitor_h = monitor.h nbsd_nat_h = nbsd-nat.h nbsd_tdep_h = nbsd-tdep.h -nto_tdep_h = nto-tdep.h $(defs_h) $(solist_h) $(osabi_h) $(regset_h) +nto_tdep_h = nto-tdep.h $(solist_h) $(osabi_h) $(regset_h) objc_lang_h = objc-lang.h objfiles_h = objfiles.h $(gdb_obstack_h) $(symfile_h) obsd_tdep_h = obsd-tdep.h @@ -2509,7 +2509,8 @@ nbsd-tdep.o: nbsd-tdep.c $(defs_h) $(gdb nto-procfs.o: nto-procfs.c $(defs_h) $(gdb_dirent_h) $(exceptions_h) \ $(gdb_string_h) $(gdbcore_h) $(inferior_h) $(target_h) $(objfiles_h) \ $(gdbthread_h) $(nto_tdep_h) $(command_h) $(regcache_h) $(solib_h) -nto-tdep.o: nto-tdep.c $(gdb_stat_h) $(gdb_string_h) $(nto_tdep_h) $(top_h) \ +nto-tdep.o: nto-tdep.c $(defs_h) $(gdb_stat_h) $(gdb_string_h) $(nto_tdep_h) \ + $(top_h) \ $(cli_decode_h) $(cli_cmds_h) $(inferior_h) $(gdbarch_h) $(bfd_h) \ $(elf_bfd_h) $(solib_svr4_h) $(gdbcore_h) $(objfiles_h) objc-exp.o: objc-exp.c $(defs_h) $(gdb_string_h) $(expression_h) \ --X3gaHHMYHkYqP6yf--