Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <vladimir@codesourcery.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>,  gdb-patches@sources.redhat.com
Subject: Re: [RFA] Inform about new thread in a single place.
Date: Fri, 14 Dec 2007 20:45:00 -0000	[thread overview]
Message-ID: <200712142343.55655.vladimir@codesourcery.com> (raw)
In-Reply-To: <20071214194721.GA2158@caradoc.them.org>

On Friday 14 December 2007 22:47:21 Daniel Jacobowitz wrote:
> On Fri, Dec 14, 2007 at 10:40:20PM +0300, Vladimir Prus wrote:
> > Here's the revised patch. OK?
> 
> linux-nat.c, linux-thread-db.c, and win32-nat.c all print only under
> control of a verbose flag.  While we're unifying the code we should
> unify the behavior too - should this always be shown, or not?

I think it should always be shown.  I find it hard to believe
that user want to know about new thread on one platform, and don't
want on another platform.

> The call site in linux-nat.c never received the verbose flag, so it
> has not been printing for a while.

Right. That's why the patch removes the print there. The ChangeLog
entry I've posted had it backward, but in reality lin_lwp_attach_lwp
is called from linux-thread-db.c:attach_thread -- which did the printing.

Now that you mention it, it appears the 'verbose' parameter can be just removed.

- Volodya


 



  reply	other threads:[~2007-12-14 20:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-14 17:14 Vladimir Prus
2007-12-14 19:07 ` Mark Kettenis
2007-12-14 19:21   ` Vladimir Prus
2007-12-14 19:42     ` Mark Kettenis
2007-12-14 19:47       ` Vladimir Prus
2007-12-14 19:55         ` Daniel Jacobowitz
2007-12-14 20:45           ` Vladimir Prus [this message]
2007-12-16 20:06           ` Eli Zaretskii
2007-12-14 20:37         ` Mark Kettenis
2007-12-14 20:49           ` Vladimir Prus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200712142343.55655.vladimir@codesourcery.com \
    --to=vladimir@codesourcery.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mark.kettenis@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox