Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: vladimir@codesourcery.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Inform about new thread in a single place.
Date: Fri, 14 Dec 2007 19:07:00 -0000	[thread overview]
Message-ID: <200712141847.lBEIljv2008865@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <200712142009.08263.vladimir@codesourcery.com> (message from 	Vladimir Prus on Fri, 14 Dec 2007 20:09:08 +0300)

> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Fri, 14 Dec 2007 20:09:08 +0300
> 
> We have lots of place where "[New thread XXX]" is printed.
> This patch makes add_thread responsible for that. OK?

No, there are places in the code where add_thread() is called where we
should not print the "[New thread xxx]" message.  For example in
bsd-uthread.c, where the main thread is added to the list of threads
to associate process ID and thread ID.

> 	Inform about new thread in a single place.
> 	* thread.c (add_thread): Announce new thread.
> 	* inf-ttrace.c (inf_ttrace_wait): Don't
> 	inform about new thread, as add_thread is always
> 	called too, and will take care of that.
> 	* infrun.c (handle_inferior_event): Likewise.
> 	* procfs.c (procfs_wait): Likewise.
> 	* remote.c (remote_currthread): Likewise.
> 	* sol-thread.c (sol_thread_wait): Likewise.
> 	* win32-nat.c (get_win32_debug_event): Likewise.
> 	* gdb/linux-nat.c (lin_lwp_attach_lwp): Likewise.
> 	* linux-thread-db.c (attach_thread): Don't inform
> 	about new thread.  This is called only from
> 	linux-thread-db.c:attach_thread, which will take care.


  reply	other threads:[~2007-12-14 18:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-14 17:14 Vladimir Prus
2007-12-14 19:07 ` Mark Kettenis [this message]
2007-12-14 19:21   ` Vladimir Prus
2007-12-14 19:42     ` Mark Kettenis
2007-12-14 19:47       ` Vladimir Prus
2007-12-14 19:55         ` Daniel Jacobowitz
2007-12-14 20:45           ` Vladimir Prus
2007-12-16 20:06           ` Eli Zaretskii
2007-12-14 20:37         ` Mark Kettenis
2007-12-14 20:49           ` Vladimir Prus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200712141847.lBEIljv2008865@brahms.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=gdb-patches@sources.redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox