From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25489 invoked by alias); 14 Dec 2007 20:44:08 -0000 Received: (qmail 25478 invoked by uid 22791); 14 Dec 2007 20:44:08 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 14 Dec 2007 20:44:02 +0000 Received: (qmail 3172 invoked from network); 14 Dec 2007 20:44:00 -0000 Received: from unknown (HELO 172.16.unknown.plus.ru) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 14 Dec 2007 20:44:00 -0000 From: Vladimir Prus To: Mark Kettenis , gdb-patches@sources.redhat.com Subject: Re: [RFA] Inform about new thread in a single place. Date: Fri, 14 Dec 2007 20:45:00 -0000 User-Agent: KMail/1.9.6 References: <200712142009.08263.vladimir@codesourcery.com> <200712142240.20597.vladimir@codesourcery.com> <20071214194721.GA2158@caradoc.them.org> In-Reply-To: <20071214194721.GA2158@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200712142343.55655.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00198.txt.bz2 On Friday 14 December 2007 22:47:21 Daniel Jacobowitz wrote: > On Fri, Dec 14, 2007 at 10:40:20PM +0300, Vladimir Prus wrote: > > Here's the revised patch. OK? > > linux-nat.c, linux-thread-db.c, and win32-nat.c all print only under > control of a verbose flag. While we're unifying the code we should > unify the behavior too - should this always be shown, or not? I think it should always be shown. I find it hard to believe that user want to know about new thread on one platform, and don't want on another platform. > The call site in linux-nat.c never received the verbose flag, so it > has not been printing for a while. Right. That's why the patch removes the print there. The ChangeLog entry I've posted had it backward, but in reality lin_lwp_attach_lwp is called from linux-thread-db.c:attach_thread -- which did the printing. Now that you mention it, it appears the 'verbose' parameter can be just removed. - Volodya