Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: Re: [RFA] Ignore breakpoints when reading memory.
Date: Tue, 04 Dec 2007 19:22:00 -0000	[thread overview]
Message-ID: <20071204192201.GA24515@caradoc.them.org> (raw)
In-Reply-To: <200712011419.45773.vladimir@codesourcery.com>

On Sat, Dec 01, 2007 at 02:19:45PM +0300, Vladimir Prus wrote:
> 
> This commit prepares us for always-inserted-breakpoints mode.
> If breakpoints are always inserted, then reading the code memory
> will read the breakpoint instructions, not the original content.
> This patch makes us try to restore the original comments using
> the breakpoints table. OK?

Doesn't this make the extra call in read_memory_nobpt redundant?

Are there any sites that need to see the breakpoint?  For instance,
look at ppc_linux_memory_remove_breakpoint.

-- 
Daniel Jacobowitz
CodeSourcery


  parent reply	other threads:[~2007-12-04 19:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-01 11:19 Vladimir Prus
2007-12-04 18:14 ` Mark Kettenis
2007-12-04 19:12   ` Jim Blandy
2008-01-21 17:19   ` Jim Blandy
2007-12-04 19:22 ` Daniel Jacobowitz [this message]
2007-12-05 22:31   ` Jim Blandy
2007-12-13 19:23     ` Vladimir Prus
2008-01-21 17:20     ` Jim Blandy
2008-01-21 18:24       ` Vladimir Prus
2008-01-21 18:37         ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071204192201.GA24515@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox