From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: vladimir@codesourcery.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Ignore breakpoints when reading memory.
Date: Tue, 04 Dec 2007 18:14:00 -0000 [thread overview]
Message-ID: <200712041811.lB4IBToM005652@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <200712011419.45773.vladimir@codesourcery.com> (message from Vladimir Prus on Sat, 1 Dec 2007 14:19:45 +0300)
> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Sat, 1 Dec 2007 14:19:45 +0300
>
> This commit prepares us for always-inserted-breakpoints mode.
> If breakpoints are always inserted, then reading the code memory
> will read the breakpoint instructions, not the original content.
> This patch makes us try to restore the original comments using
> the breakpoints table. OK?
So now reading from target memory will need to traverse the complete
list of inserted breakpoints. Did you do any benchmarking to see what
the impact of this change is, especially when running on a somewhat
slow machine?
> * breakpoint.h (breakpoint_restore_shadows): New
> declaration.
> * breakpoint.c (breakpoint_restore_shadows): New.
> (read_memory_nobpt): Use breakpoint_restore_shadows.
> * target.c (memory_xfer_partial): Call
> breakpoint_restore_shadows.
next prev parent reply other threads:[~2007-12-04 18:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-01 11:19 Vladimir Prus
2007-12-04 18:14 ` Mark Kettenis [this message]
2007-12-04 19:12 ` Jim Blandy
2008-01-21 17:19 ` Jim Blandy
2007-12-04 19:22 ` Daniel Jacobowitz
2007-12-05 22:31 ` Jim Blandy
2007-12-13 19:23 ` Vladimir Prus
2008-01-21 17:20 ` Jim Blandy
2008-01-21 18:24 ` Vladimir Prus
2008-01-21 18:37 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712041811.lB4IBToM005652@brahms.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sources.redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox