From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-52535-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23285 invoked by alias); 4 Dec 2007 18:14:17 -0000
Received: (qmail 23273 invoked by uid 22791); 4 Dec 2007 18:14:16 -0000
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO brahms.sibelius.xs4all.nl) (82.92.89.47)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 04 Dec 2007 18:14:12 +0000
Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) 	by brahms.sibelius.xs4all.nl (8.14.1/8.14.0) with ESMTP id lB4IBUX6019703; 	Tue, 4 Dec 2007 19:11:30 +0100 (CET)
Received: (from kettenis@localhost) 	by brahms.sibelius.xs4all.nl (8.14.1/8.14.1/Submit) id lB4IBToM005652; 	Tue, 4 Dec 2007 19:11:29 +0100 (CET)
Date: Tue, 04 Dec 2007 18:14:00 -0000
Message-Id: <200712041811.lB4IBToM005652@brahms.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: vladimir@codesourcery.com
CC: gdb-patches@sources.redhat.com
In-reply-to: <200712011419.45773.vladimir@codesourcery.com> (message from 	Vladimir Prus on Sat, 1 Dec 2007 14:19:45 +0300)
Subject: Re: [RFA] Ignore breakpoints when reading memory.
References:  <200712011419.45773.vladimir@codesourcery.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-12/txt/msg00057.txt.bz2

> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Sat, 1 Dec 2007 14:19:45 +0300
> 
> This commit prepares us for always-inserted-breakpoints mode.
> If breakpoints are always inserted, then reading the code memory
> will read the breakpoint instructions, not the original content.
> This patch makes us try to restore the original comments using
> the breakpoints table. OK?

So now reading from target memory will need to traverse the complete
list of inserted breakpoints.  Did you do any benchmarking to see what
the impact of this change is, especially when running on a somewhat
slow machine?

> 	* breakpoint.h (breakpoint_restore_shadows): New
> 	declaration.
> 	* breakpoint.c (breakpoint_restore_shadows): New.
> 	(read_memory_nobpt): Use breakpoint_restore_shadows.
> 	* target.c (memory_xfer_partial): Call
> 	breakpoint_restore_shadows.