From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25425 invoked by alias); 4 Dec 2007 19:22:14 -0000 Received: (qmail 25416 invoked by uid 22791); 4 Dec 2007 19:22:14 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 04 Dec 2007 19:22:04 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 216E29833F for ; Tue, 4 Dec 2007 19:22:03 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 0BC8698100 for ; Tue, 4 Dec 2007 19:22:03 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1IzdLF-0006O2-FW for gdb-patches@sourceware.org; Tue, 04 Dec 2007 14:22:01 -0500 Date: Tue, 04 Dec 2007 19:22:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: [RFA] Ignore breakpoints when reading memory. Message-ID: <20071204192201.GA24515@caradoc.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <200712011419.45773.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200712011419.45773.vladimir@codesourcery.com> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00059.txt.bz2 On Sat, Dec 01, 2007 at 02:19:45PM +0300, Vladimir Prus wrote: > > This commit prepares us for always-inserted-breakpoints mode. > If breakpoints are always inserted, then reading the code memory > will read the breakpoint instructions, not the original content. > This patch makes us try to restore the original comments using > the breakpoints table. OK? Doesn't this make the extra call in read_memory_nobpt redundant? Are there any sites that need to see the breakpoint? For instance, look at ppc_linux_memory_remove_breakpoint. -- Daniel Jacobowitz CodeSourcery