From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Cc: Pierre Muller <muller@ics.u-strasbg.fr>
Subject: Re: [RFA v2] Allow cygwin native to compile with --enable-64-bit-bfd
Date: Sun, 02 Dec 2007 04:00:00 -0000 [thread overview]
Message-ID: <20071202040023.GA20011@caradoc.them.org> (raw)
In-Reply-To: <20071202024311.GB15745@ednor.casa.cgf.cx>
On Sat, Dec 01, 2007 at 09:43:11PM -0500, Christopher Faylor wrote:
> I'd like to get opinions from other maintainers on the use of a macro
> for this case. I don't like seeing unexplained double casts like this
> and I think a macro could make it clearer.
>
> Daniel were you implying that you would just tolerate a macro here or
> do you think it's an ok idea.
I'm very familiar with this idiom, so the double cast stands out when
I see it. If there were a macro I'd have to go figure out whether it
was doing something more subtle. I'd write it this way, but not
complain if someone else wrote it differently.
> >2007-11-28 Pierre Muller <muller@ics.u-strasbg.fr>
> >
> > *win32-nat.c: Allow compilation if CORE_ADDR is 8 byte long.
> > Add "gdb_stdint.h" dependency required for uintptr_t type use.
Added includes -> update Makefile.in. Tom's been working on automatic
dependencies for GCC. Maybe we can do something similar for GDB
soon...
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-12-02 4:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-23 8:50 [RFC/RFA] " Pierre Muller
2007-11-24 21:07 ` Christopher Faylor
2007-11-24 22:47 ` Daniel Jacobowitz
2007-11-25 17:32 ` Christopher Faylor
2007-11-25 19:08 ` Daniel Jacobowitz
2007-11-25 22:12 ` Christopher Faylor
2007-11-26 9:12 ` Pierre Muller
2007-11-26 15:18 ` Ulrich Weigand
2007-11-29 10:11 ` [RFA v2] " Pierre Muller
2007-12-02 2:43 ` Christopher Faylor
2007-12-02 4:00 ` Daniel Jacobowitz [this message]
2007-12-03 15:18 ` [RFA v3] " Pierre Muller
2007-12-06 9:23 ` Christopher Faylor
2007-12-06 14:06 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071202040023.GA20011@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=muller@ics.u-strasbg.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox