Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>
To: gdb-patches@sourceware.org
Subject: Re: [RFC/RFA] Allow cygwin native to compile with 	--enable-64-bit-bfd
Date: Sun, 25 Nov 2007 22:12:00 -0000	[thread overview]
Message-ID: <20071125221238.GB10356@ednor.casa.cgf.cx> (raw)
In-Reply-To: <20071125190823.GA11606@caradoc.them.org>

On Sun, Nov 25, 2007 at 02:08:23PM -0500, Daniel Jacobowitz wrote:
>On Sun, Nov 25, 2007 at 12:32:08PM -0500, Christopher Faylor wrote:
>> On Sat, Nov 24, 2007 at 05:47:27PM -0500, Daniel Jacobowitz wrote:
>> >On Sat, Nov 24, 2007 at 04:07:08PM -0500, Christopher Faylor wrote:
>> >> >   if (!target_read_string
>> >> >-    ((CORE_ADDR) current_event.u.DebugString.lpDebugStringData, &s, 1024,
>> >> >0)
>> >> >+    ((CORE_ADDR) addr, &s, 1024, 0)
>> >> 
>> >> How can coercing something to uintptr_t and then to CORE_ADDR achieve
>> >> anything?  How does the double coercion help?
>> >
>> >Just the warning.  CORE_ADDR will be long long,
>> >current_event.u.DebugString.lpDebugStringData will apparently be a pointer.
>> 
>> And the warning is?
>
>Cast from pointer to integer of different size.  Casts are the way
>we've handled it elsewhere in GDB, but I wouldn't complain about a
>wrapper; casting host pointers to CORE_ADDRs is an action we try to
>keep to a minimum anyway.

I wouldn't mind a double cast either, if there is precedent for that.

cgf


  reply	other threads:[~2007-11-25 22:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-23  8:50 Pierre Muller
2007-11-24 21:07 ` Christopher Faylor
2007-11-24 22:47   ` Daniel Jacobowitz
2007-11-25 17:32     ` Christopher Faylor
2007-11-25 19:08       ` Daniel Jacobowitz
2007-11-25 22:12         ` Christopher Faylor [this message]
2007-11-26  9:12           ` Pierre Muller
2007-11-26 15:18             ` Ulrich Weigand
2007-11-29 10:11           ` [RFA v2] " Pierre Muller
2007-12-02  2:43             ` Christopher Faylor
2007-12-02  4:00               ` Daniel Jacobowitz
2007-12-03 15:18                 ` [RFA v3] " Pierre Muller
2007-12-06  9:23                   ` Christopher Faylor
2007-12-06 14:06                     ` Pierre Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071125221238.GB10356@ednor.casa.cgf.cx \
    --to=cgf-use-the-mailinglist-please@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox