From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27692 invoked by alias); 2 Dec 2007 04:00:33 -0000 Received: (qmail 27684 invoked by uid 22791); 2 Dec 2007 04:00:33 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 02 Dec 2007 04:00:27 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id E918698249; Sun, 2 Dec 2007 04:00:24 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id AA60D98248; Sun, 2 Dec 2007 04:00:24 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1Iyg0F-0005D4-Kr; Sat, 01 Dec 2007 23:00:23 -0500 Date: Sun, 02 Dec 2007 04:00:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Cc: Pierre Muller Subject: Re: [RFA v2] Allow cygwin native to compile with --enable-64-bit-bfd Message-ID: <20071202040023.GA20011@caradoc.them.org> Mail-Followup-To: gdb-patches@sourceware.org, Pierre Muller References: <000001c82dad$e507e0b0$af17a210$@u-strasbg.fr> <20071124210708.GE4928@ednor.casa.cgf.cx> <20071124224727.GA13580@caradoc.them.org> <20071125173207.GA7689@ednor.casa.cgf.cx> <20071125190823.GA11606@caradoc.them.org> <20071125221238.GB10356@ednor.casa.cgf.cx> <000901c83270$2a7f7060$7f7e5120$@u-strasbg.fr> <20071202024311.GB15745@ednor.casa.cgf.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071202024311.GB15745@ednor.casa.cgf.cx> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00030.txt.bz2 On Sat, Dec 01, 2007 at 09:43:11PM -0500, Christopher Faylor wrote: > I'd like to get opinions from other maintainers on the use of a macro > for this case. I don't like seeing unexplained double casts like this > and I think a macro could make it clearer. > > Daniel were you implying that you would just tolerate a macro here or > do you think it's an ok idea. I'm very familiar with this idiom, so the double cast stands out when I see it. If there were a macro I'd have to go figure out whether it was doing something more subtle. I'd write it this way, but not complain if someone else wrote it differently. > >2007-11-28 Pierre Muller > > > > *win32-nat.c: Allow compilation if CORE_ADDR is 8 byte long. > > Add "gdb_stdint.h" dependency required for uintptr_t type use. Added includes -> update Makefile.in. Tom's been working on automatic dependencies for GCC. Maybe we can do something similar for GDB soon... -- Daniel Jacobowitz CodeSourcery