From: Daniel Jacobowitz <drow@false.org>
To: Rob Quill <rob.quill@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Remove deprecated_set_value_type
Date: Tue, 13 Nov 2007 12:40:00 -0000 [thread overview]
Message-ID: <20071113124021.GB22747@caradoc.them.org> (raw)
In-Reply-To: <baf6008d0711130201i20bae460r71d56216d0f02f38@mail.gmail.com>
On Tue, Nov 13, 2007 at 10:01:11AM +0000, Rob Quill wrote:
> Hi,
>
> This patch removes the deprecated_set_value_type() function from
> value.c, value.h and all other places which use it.
>
> I also plan to try and remove the other deprecated functions from value.c
Sorry, but you've missed the point. It was deprecated because you're
not supposed to bang on a value's type after it is created (or at
least, that's the hope). And struct value was moved from the header
to the C file in order to stop other places from poking at it.
So this is going the wrong direction :-(
> -/* This is being used to change the type of an existing value, that
> - code should instead be creating a new value with the changed type
> - (but possibly shared content). */
As that says.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-11-13 12:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-13 10:01 Rob Quill
2007-11-13 12:40 ` Daniel Jacobowitz [this message]
2007-11-13 14:26 ` Rob Quill
2007-11-13 19:23 ` Rob Quill
2007-12-16 20:50 ` Daniel Jacobowitz
2007-12-17 10:40 ` Rob Quill
2008-01-17 8:06 ` Rob Quill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071113124021.GB22747@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=rob.quill@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox