From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19315 invoked by alias); 13 Nov 2007 12:40:26 -0000 Received: (qmail 19300 invoked by uid 22791); 13 Nov 2007 12:40:25 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 13 Nov 2007 12:40:23 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 5A7179835E; Tue, 13 Nov 2007 12:40:22 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 3182E98349; Tue, 13 Nov 2007 12:40:22 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1Irv41-0005zl-9W; Tue, 13 Nov 2007 07:40:21 -0500 Date: Tue, 13 Nov 2007 12:40:00 -0000 From: Daniel Jacobowitz To: Rob Quill Cc: gdb-patches@sourceware.org Subject: Re: Remove deprecated_set_value_type Message-ID: <20071113124021.GB22747@caradoc.them.org> Mail-Followup-To: Rob Quill , gdb-patches@sourceware.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00241.txt.bz2 On Tue, Nov 13, 2007 at 10:01:11AM +0000, Rob Quill wrote: > Hi, > > This patch removes the deprecated_set_value_type() function from > value.c, value.h and all other places which use it. > > I also plan to try and remove the other deprecated functions from value.c Sorry, but you've missed the point. It was deprecated because you're not supposed to bang on a value's type after it is created (or at least, that's the hope). And struct value was moved from the header to the C file in order to stop other places from poking at it. So this is going the wrong direction :-( > -/* This is being used to change the type of an existing value, that > - code should instead be creating a new value with the changed type > - (but possibly shared content). */ As that says. -- Daniel Jacobowitz CodeSourcery