Re: Remove deprecated_set_value_type

["Rob Quill" <rob.quill@gmail.com>]

On 13/11/2007, Rob Quill <rob.quill@gmail.com> wrote:
> On 13/11/2007, Daniel Jacobowitz <drow@false.org> wrote:
> > On Tue, Nov 13, 2007 at 10:01:11AM +0000, Rob Quill wrote:
> > > Hi,
> > >
> > > This patch removes the deprecated_set_value_type() function from
> > > value.c, value.h and all other places which use it.
> > >
> > > I also plan to try and remove the other deprecated functions from value.c
> >
> > Sorry, but you've missed the point.  It was deprecated because you're
> > not supposed to bang on a value's type after it is created (or at
> > least, that's the hope).  And struct value was moved from the header
> > to the C file in order to stop other places from poking at it.
> >
> > So this is going the wrong direction :-(
> >
> > > -/* This is being used to change the type of an existing value, that
> > > -   code should instead be creating a new value with the changed type
> > > -   (but possibly shared content).  */
> >
> > As that says.

Is it a correct solution to add a function something like
copy_val_except_type, which copies all the fields from a value struct
except the type? So an new value is created of the right type, then
cop_val_except_type is called, which would replace the other fields.

Thanks for your help,
Rob