Re: [rfc] [00/15] Add gdbarch to register_name callback

["Ulrich Weigand" <uweigand@de.ibm.com>]

Markus Deuling wrote:

> I attached a new patch which is nearly a merge of the last 15 patches. I included the trivial replacements
> of current_gdbarch (by gdbarch, get_frame_arch or get_regcache_arch). The patch does not contain the non-trivial
> replacements like dissolving macros etc anymore. I'll follow-up on that after this on is committed.

Thanks for re-working the patch.  

> > Otherwise, the changes look fine to me.
> 
> I also changed "M" to "m" for register_name and introduced a new default_register_name function that just returns NULL.

Ah, this was not quite what I had in mind, sorry.  I do not think
it makes sense to have a "default_register_name" -- every gdbarch
*must* provide a register_name function.  I was thinking of something
along the lines of

m:const char *:register_name:int regnr:regnr::0

This will cause verify_gdbarch to abort if no register_name is
registered.

Could you make that change and re-submit?  The rest of the
patch is OK.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com