From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29859 invoked by alias); 1 Nov 2007 15:22:08 -0000 Received: (qmail 29847 invoked by uid 22791); 1 Nov 2007 15:22:07 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate7.de.ibm.com (HELO mtagate7.de.ibm.com) (195.212.29.156) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 01 Nov 2007 15:22:05 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate7.de.ibm.com (8.13.8/8.13.8) with ESMTP id lA1FM160139760 for ; Thu, 1 Nov 2007 15:22:01 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id lA1FM2YL1618018 for ; Thu, 1 Nov 2007 16:22:02 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id lA1FM1P8017807 for ; Thu, 1 Nov 2007 16:22:01 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id lA1FM1eN017802; Thu, 1 Nov 2007 16:22:01 +0100 Message-Id: <200711011522.lA1FM1eN017802@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Thu, 1 Nov 2007 16:22:01 +0100 Subject: Re: [rfc] [00/15] Add gdbarch to register_name callback To: deuling@de.ibm.com (Markus Deuling) Date: Thu, 01 Nov 2007 15:22:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org (GDB Patches), brobecker@adacore.com (Joel Brobecker), drow@false.org (Daniel Jacobowitz), eliz@gnu.org (Eli Zaretskii), mark.kettenis@xs4all.nl (Mark Kettenis) In-Reply-To: <47298E06.6090108@de.ibm.com> from "Markus Deuling" at Nov 01, 2007 09:27:50 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00009.txt.bz2 Markus Deuling wrote: > I attached a new patch which is nearly a merge of the last 15 patches. I included the trivial replacements > of current_gdbarch (by gdbarch, get_frame_arch or get_regcache_arch). The patch does not contain the non-trivial > replacements like dissolving macros etc anymore. I'll follow-up on that after this on is committed. Thanks for re-working the patch. > > Otherwise, the changes look fine to me. > > I also changed "M" to "m" for register_name and introduced a new default_register_name function that just returns NULL. Ah, this was not quite what I had in mind, sorry. I do not think it makes sense to have a "default_register_name" -- every gdbarch *must* provide a register_name function. I was thinking of something along the lines of m:const char *:register_name:int regnr:regnr::0 This will cause verify_gdbarch to abort if no register_name is registered. Could you make that change and re-submit? The rest of the patch is OK. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com