From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: deuling@de.ibm.com (Markus Deuling)
Cc: gdb-patches@sourceware.org (GDB Patches),
brobecker@adacore.com (Joel Brobecker),
drow@false.org (Daniel Jacobowitz),
eliz@gnu.org (Eli Zaretskii),
mark.kettenis@xs4all.nl (Mark Kettenis)
Subject: Re: [rfc] [00/15] Add gdbarch to register_name callback
Date: Wed, 31 Oct 2007 23:46:00 -0000 [thread overview]
Message-ID: <200710312159.l9VLxkBu026498@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <47285CC5.9020403@de.ibm.com> from "Markus Deuling" at Oct 31, 2007 11:45:25 AM
Markus Deuling wrote:
> All 15 patches depend on each other. Leaving one out at commit will break one or more targets.
Sorry, but it doesn't make sense to split it into distinct patches then.
Every patch should be a self-contained unit (e.g. to allow reverting a
commit if that turns out to be necessary later on).
Could you please merge all co-dependent changes into a single patch
and ChangeLog? On the other hand, some of the patches contain
additional changes unrelated to the register_name prototype change
-- *those* should be broken out into a second patch.
Otherwise, the changes look fine to me.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2007-10-31 21:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-31 10:47 Markus Deuling
2007-10-31 23:46 ` Ulrich Weigand [this message]
2007-11-01 8:30 ` Markus Deuling
2007-11-01 15:22 ` Ulrich Weigand
2007-11-02 8:09 ` Markus Deuling
2007-11-02 14:28 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710312159.l9VLxkBu026498@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=brobecker@adacore.com \
--cc=deuling@de.ibm.com \
--cc=drow@false.org \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox