From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19372 invoked by alias); 31 Oct 2007 21:59:55 -0000 Received: (qmail 19358 invoked by uid 22791); 31 Oct 2007 21:59:54 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate4.de.ibm.com (HELO mtagate4.de.ibm.com) (195.212.29.153) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 31 Oct 2007 21:59:50 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate4.de.ibm.com (8.13.8/8.13.8) with ESMTP id l9VLxlew092114 for ; Wed, 31 Oct 2007 21:59:47 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id l9VLxlSx2215970 for ; Wed, 31 Oct 2007 22:59:47 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l9VLxkXT026501 for ; Wed, 31 Oct 2007 22:59:47 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l9VLxkBu026498; Wed, 31 Oct 2007 22:59:46 +0100 Message-Id: <200710312159.l9VLxkBu026498@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 31 Oct 2007 22:59:46 +0100 Subject: Re: [rfc] [00/15] Add gdbarch to register_name callback To: deuling@de.ibm.com (Markus Deuling) Date: Wed, 31 Oct 2007 23:46:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org (GDB Patches), brobecker@adacore.com (Joel Brobecker), drow@false.org (Daniel Jacobowitz), eliz@gnu.org (Eli Zaretskii), mark.kettenis@xs4all.nl (Mark Kettenis) In-Reply-To: <47285CC5.9020403@de.ibm.com> from "Markus Deuling" at Oct 31, 2007 11:45:25 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00879.txt.bz2 Markus Deuling wrote: > All 15 patches depend on each other. Leaving one out at commit will break one or more targets. Sorry, but it doesn't make sense to split it into distinct patches then. Every patch should be a self-contained unit (e.g. to allow reverting a commit if that turns out to be necessary later on). Could you please merge all co-dependent changes into a single patch and ChangeLog? On the other hand, some of the patches contain additional changes unrelated to the register_name prototype change -- *those* should be broken out into a second patch. Otherwise, the changes look fine to me. Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com