Re: [patch 1/4] libdecnumber support

[Daniel Jacobowitz <drow@false.org>]

On Mon, Oct 15, 2007 at 04:10:57PM -0200, Thiago Jung Bauermann wrote:
> Ok, I'm using it now. When I run autoreconf inside the src/gdb
> directory, I get the following:
> 
> $ autoreconf
> autoreconf: cannot create `cd $srcdir;pwd`/../../../..: No such file or
> directory
> autoreconf: cannot create `cd $srcdir;pwd`/../../..: No such file or
> directory
> autoreconf: cannot create `cd $srcdir;pwd`/..: No such file or directory
> $ echo $?
> 0
> 
> Is this a problem? Things still seem to work fine. I used autoconf
> version 2.61.

I have not tried autoreconf.  It's helpful to use the same version
that was used last time, when not deliberately upgrading autoconf;
in this case that's 2.59.  I keep a separate installation of it around
for this purpose, and run autoconf + autoheader by hand.

> > > +        break;
> > > +      default:
> > > +	free (dec);
> > 
> > Spaces and tabs mixed up?  xfree, like xmalloc.
> 
> Fixed. No '\t' in the file now. By the way, what's the policy in GDB
> w.r.t. tabs and spaces? Never use tabs?

Our policy is to always use leading tabs; so whenever you have eight
spaces at the line it becomes a tab.  This comes, of course, from
emacs :-)

Aside from leading spaces, and using autoconf 2.59, this version is
OK.  I added libdecnumber last week, so all should be ready now.

-- 
Daniel Jacobowitz
CodeSourcery