From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21861 invoked by alias); 15 Oct 2007 18:32:10 -0000 Received: (qmail 21814 invoked by uid 22791); 15 Oct 2007 18:32:10 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 15 Oct 2007 18:32:03 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 248E198338; Mon, 15 Oct 2007 18:32:01 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 080A19810B; Mon, 15 Oct 2007 18:32:00 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1IhUjP-0000gl-MB; Mon, 15 Oct 2007 14:31:59 -0400 Date: Mon, 15 Oct 2007 18:38:00 -0000 From: Daniel Jacobowitz To: Thiago Jung Bauermann Cc: gdb-patches@sourceware.org Subject: Re: [patch 1/4] libdecnumber support Message-ID: <20071015183159.GA2448@caradoc.them.org> Mail-Followup-To: Thiago Jung Bauermann , gdb-patches@sourceware.org References: <20070920215410.062714003@br.ibm.com> <20070920215539.570827491@br.ibm.com> <20071011155418.GA22982@caradoc.them.org> <1192471857.5787.44.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1192471857.5787.44.camel@localhost.localdomain> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00399.txt.bz2 On Mon, Oct 15, 2007 at 04:10:57PM -0200, Thiago Jung Bauermann wrote: > Ok, I'm using it now. When I run autoreconf inside the src/gdb > directory, I get the following: > > $ autoreconf > autoreconf: cannot create `cd $srcdir;pwd`/../../../..: No such file or > directory > autoreconf: cannot create `cd $srcdir;pwd`/../../..: No such file or > directory > autoreconf: cannot create `cd $srcdir;pwd`/..: No such file or directory > $ echo $? > 0 > > Is this a problem? Things still seem to work fine. I used autoconf > version 2.61. I have not tried autoreconf. It's helpful to use the same version that was used last time, when not deliberately upgrading autoconf; in this case that's 2.59. I keep a separate installation of it around for this purpose, and run autoconf + autoheader by hand. > > > + break; > > > + default: > > > + free (dec); > > > > Spaces and tabs mixed up? xfree, like xmalloc. > > Fixed. No '\t' in the file now. By the way, what's the policy in GDB > w.r.t. tabs and spaces? Never use tabs? Our policy is to always use leading tabs; so whenever you have eight spaces at the line it becomes a tab. This comes, of course, from emacs :-) Aside from leading spaces, and using autoconf 2.59, this version is OK. I added libdecnumber last week, so all should be ready now. -- Daniel Jacobowitz CodeSourcery