Re: [rfc] Improve NetBSD/i386 signal trampoline detection

[Nick Hudson <nick.hudson@dsl.pipex.com>]

On Thursday 11 October 2007 19:04:28 Daniel Jacobowitz wrote:
> On Tue, Oct 02, 2007 at 12:07:15PM +0100, Nick Hudson wrote:
> > Hi,
> >
> > I put together this patch to improve NetBSD/i386 signal trampoline
> > detection. I believe tramp_frame is a better and preferred method.
> >
> > I think I need to add the instructions for when the setcontext/sigreturn
> > fails as well. Is this correct?
> >
> > Any/all comments appreciated.
>
> Trivial comments: you've added #includes so Makefile.in needs an
> update (maybe I'll do automatic dependencies sometime soon);

I'll fix this

> please include a ChangeLog with all patches;

sure, but I was mostly checking I was going the right way.

> do you have a copyright assignment?

Yep.

> Does this fix a problem, or are you just cleaning up?

Both really. gdb doesn't understand the signal trampolines used by newer 
versions of NetBSD.

> As for the patch itself I'm hoping Mark Kettenis can look at it; he's
> both the i386 port and FreeBSD maintainer, which is not all that close
> to an i386-netbsd maintainer but it's the closest we have.

OK, thanks for the comments.

I'll post a new patch after I get Mark's comments.

Cheers,
Nick