From: Daniel Jacobowitz <drow@false.org>
To: Nick Hudson <nick.hudson@dsl.pipex.com>
Cc: gdb-patches@sourceware.org, Mark Kettenis <kettenis@gnu.org>
Subject: Re: [rfc] Improve NetBSD/i386 signal trampoline detection
Date: Thu, 11 Oct 2007 18:06:00 -0000 [thread overview]
Message-ID: <20071011180428.GF28658@caradoc.them.org> (raw)
In-Reply-To: <200710021207.16451.nick.hudson@dsl.pipex.com>
On Tue, Oct 02, 2007 at 12:07:15PM +0100, Nick Hudson wrote:
> Hi,
>
> I put together this patch to improve NetBSD/i386 signal trampoline detection.
> I believe tramp_frame is a better and preferred method.
>
> I think I need to add the instructions for when the setcontext/sigreturn fails
> as well. Is this correct?
>
> Any/all comments appreciated.
Trivial comments: you've added #includes so Makefile.in needs an
update (maybe I'll do automatic dependencies sometime soon); please
include a ChangeLog with all patches; do you have a copyright
assignment?
Does this fix a problem, or are you just cleaning up?
As for the patch itself I'm hoping Mark Kettenis can look at it; he's
both the i386 port and FreeBSD maintainer, which is not all that close
to an i386-netbsd maintainer but it's the closest we have.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-10-11 18:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-02 11:07 Nick Hudson
2007-10-11 18:06 ` Daniel Jacobowitz [this message]
2007-10-11 18:41 ` Nick Hudson
2007-10-11 19:14 ` Mark Kettenis
2007-10-19 4:13 ` Nick Hudson
2007-11-02 8:02 ` Nick Hudson
2007-12-16 19:10 ` Daniel Jacobowitz
2007-12-16 20:30 ` Mark Kettenis
2007-12-16 20:48 ` Daniel Jacobowitz
2007-12-29 18:01 ` Mark Kettenis
2007-12-30 0:33 ` Daniel Jacobowitz
2007-12-30 15:21 ` Nick Hudson
2007-12-30 17:08 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071011180428.GF28658@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=kettenis@gnu.org \
--cc=nick.hudson@dsl.pipex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox