From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13250 invoked by alias); 11 Oct 2007 18:04:50 -0000 Received: (qmail 13177 invoked by uid 22791); 11 Oct 2007 18:04:32 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 11 Oct 2007 18:04:30 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 55EC5981F3; Thu, 11 Oct 2007 18:04:29 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 23AE1981F2; Thu, 11 Oct 2007 18:04:29 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1Ig2Oa-0003cy-Ds; Thu, 11 Oct 2007 14:04:28 -0400 Date: Thu, 11 Oct 2007 18:06:00 -0000 From: Daniel Jacobowitz To: Nick Hudson Cc: gdb-patches@sourceware.org, Mark Kettenis Subject: Re: [rfc] Improve NetBSD/i386 signal trampoline detection Message-ID: <20071011180428.GF28658@caradoc.them.org> Mail-Followup-To: Nick Hudson , gdb-patches@sourceware.org, Mark Kettenis References: <200710021207.16451.nick.hudson@dsl.pipex.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200710021207.16451.nick.hudson@dsl.pipex.com> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00308.txt.bz2 On Tue, Oct 02, 2007 at 12:07:15PM +0100, Nick Hudson wrote: > Hi, > > I put together this patch to improve NetBSD/i386 signal trampoline detection. > I believe tramp_frame is a better and preferred method. > > I think I need to add the instructions for when the setcontext/sigreturn fails > as well. Is this correct? > > Any/all comments appreciated. Trivial comments: you've added #includes so Makefile.in needs an update (maybe I'll do automatic dependencies sometime soon); please include a ChangeLog with all patches; do you have a copyright assignment? Does this fix a problem, or are you just cleaning up? As for the patch itself I'm hoping Mark Kettenis can look at it; he's both the i386 port and FreeBSD maintainer, which is not all that close to an i386-netbsd maintainer but it's the closest we have. -- Daniel Jacobowitz CodeSourcery