From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3301 invoked by alias); 11 Oct 2007 18:40:40 -0000 Received: (qmail 3293 invoked by uid 22791); 11 Oct 2007 18:40:39 -0000 X-Spam-Check-By: sourceware.org Received: from galaxy.systems.pipex.net (HELO galaxy.systems.pipex.net) (62.241.162.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 11 Oct 2007 18:40:35 +0000 Received: from [10.1.0.2] (81-178-15-87.dsl.pipex.com [81.178.15.87]) by galaxy.systems.pipex.net (Postfix) with ESMTP id BD4D5E000498; Thu, 11 Oct 2007 19:40:31 +0100 (BST) From: Nick Hudson To: Daniel Jacobowitz Subject: Re: [rfc] Improve NetBSD/i386 signal trampoline detection Date: Thu, 11 Oct 2007 18:41:00 -0000 User-Agent: KMail/1.9.7 Cc: gdb-patches@sourceware.org, Mark Kettenis References: <200710021207.16451.nick.hudson@dsl.pipex.com> <20071011180428.GF28658@caradoc.them.org> In-Reply-To: <20071011180428.GF28658@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200710111940.25607.nick.hudson@dsl.pipex.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00312.txt.bz2 On Thursday 11 October 2007 19:04:28 Daniel Jacobowitz wrote: > On Tue, Oct 02, 2007 at 12:07:15PM +0100, Nick Hudson wrote: > > Hi, > > > > I put together this patch to improve NetBSD/i386 signal trampoline > > detection. I believe tramp_frame is a better and preferred method. > > > > I think I need to add the instructions for when the setcontext/sigreturn > > fails as well. Is this correct? > > > > Any/all comments appreciated. > > Trivial comments: you've added #includes so Makefile.in needs an > update (maybe I'll do automatic dependencies sometime soon); I'll fix this > please include a ChangeLog with all patches; sure, but I was mostly checking I was going the right way. > do you have a copyright assignment? Yep. > Does this fix a problem, or are you just cleaning up? Both really. gdb doesn't understand the signal trampolines used by newer versions of NetBSD. > As for the patch itself I'm hoping Mark Kettenis can look at it; he's > both the i386 port and FreeBSD maintainer, which is not all that close > to an i386-netbsd maintainer but it's the closest we have. OK, thanks for the comments. I'll post a new patch after I get Mark's comments. Cheers, Nick