From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: drow@false.org (Daniel Jacobowitz)
Cc: deuling@de.ibm.com (Markus Deuling),
gdb-patches@sourceware.org (GDB Patches),
brobecker@adacore.com (Joel Brobecker),
maxim@tensilica.com (Maxim Grigoriev)
Subject: Re: [rfc] [0/8] Get rid of current_gdbarch
Date: Tue, 09 Oct 2007 18:54:00 -0000 [thread overview]
Message-ID: <200710091844.l99IivIO031991@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <20071009183424.GA31971@caradoc.them.org> from "Daniel Jacobowitz" at Oct 09, 2007 02:34:24 PM
Daniel Jacobowitz wrote:
> On Tue, Oct 09, 2007 at 08:22:45PM +0200, Ulrich Weigand wrote:
> > At this point, there's no need to involve get_current_frame. The
> > routine operates on the current regcache, and should simply consult
> > its architecture.
>
> As a more general note, replacing one global state with another is of
> limited value. It's not completely useless, but let's avoid it when
> we can :-)
Well, in some cases you have to have some global state ... At this
point, which is the implementation of the "return" command, you have
no other context -- the command by design operates on the "current"
register set ... (That still doesn't mean it should refer to
current_gdbarch at this point, that makes a lot more assumptions.)
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2007-10-09 18:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-09 11:39 Markus Deuling
2007-10-09 18:34 ` Ulrich Weigand
2007-10-09 18:45 ` Daniel Jacobowitz
2007-10-09 18:54 ` Ulrich Weigand [this message]
2007-10-09 19:50 ` Maxim Grigoriev
2007-10-09 19:59 ` Ulrich Weigand
2007-10-10 5:14 ` Markus Deuling
2007-10-10 8:09 ` Markus Deuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710091844.l99IivIO031991@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=brobecker@adacore.com \
--cc=deuling@de.ibm.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=maxim@tensilica.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox