From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10376 invoked by alias); 9 Oct 2007 18:45:05 -0000 Received: (qmail 10365 invoked by uid 22791); 9 Oct 2007 18:45:04 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate4.de.ibm.com (HELO mtagate4.de.ibm.com) (195.212.29.153) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 09 Oct 2007 18:45:00 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate4.de.ibm.com (8.13.8/8.13.8) with ESMTP id l99IivEI070298 for ; Tue, 9 Oct 2007 18:44:57 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id l99IivU62191422 for ; Tue, 9 Oct 2007 20:44:57 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l99IivKQ031996 for ; Tue, 9 Oct 2007 20:44:57 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l99IivIO031991; Tue, 9 Oct 2007 20:44:57 +0200 Message-Id: <200710091844.l99IivIO031991@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 9 Oct 2007 20:44:57 +0200 Subject: Re: [rfc] [0/8] Get rid of current_gdbarch To: drow@false.org (Daniel Jacobowitz) Date: Tue, 09 Oct 2007 18:54:00 -0000 From: "Ulrich Weigand" Cc: deuling@de.ibm.com (Markus Deuling), gdb-patches@sourceware.org (GDB Patches), brobecker@adacore.com (Joel Brobecker), maxim@tensilica.com (Maxim Grigoriev) In-Reply-To: <20071009183424.GA31971@caradoc.them.org> from "Daniel Jacobowitz" at Oct 09, 2007 02:34:24 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00212.txt.bz2 Daniel Jacobowitz wrote: > On Tue, Oct 09, 2007 at 08:22:45PM +0200, Ulrich Weigand wrote: > > At this point, there's no need to involve get_current_frame. The > > routine operates on the current regcache, and should simply consult > > its architecture. > > As a more general note, replacing one global state with another is of > limited value. It's not completely useless, but let's avoid it when > we can :-) Well, in some cases you have to have some global state ... At this point, which is the implementation of the "return" command, you have no other context -- the command by design operates on the "current" register set ... (That still doesn't mean it should refer to current_gdbarch at this point, that makes a lot more assumptions.) Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com